Skip to content

Implement notesInfo#46

Closed
Aquafina-water-bottle wants to merge 20 commits intoKamWithK:masterfrom
Aquafina-water-bottle:notesInfo
Closed

Implement notesInfo#46
Aquafina-water-bottle wants to merge 20 commits intoKamWithK:masterfrom
Aquafina-water-bottle:notesInfo

Conversation

@Aquafina-water-bottle
Copy link
Copy Markdown
Contributor

@Aquafina-water-bottle Aquafina-water-bottle commented Jun 19, 2023

TODO:

  • Refactor the code? Private internal classes or move them to different files?
  • Shouldn't have null returns / continues. If a note id is not found, it should result in an empty JSON object.

Depends on #43

@precondition
Copy link
Copy Markdown

precondition commented Jan 2, 2024

After a small update to the Anki Android API dependency, I managed to build this version and it seems to work well enough to solve the issue raised in #50. Since it seems like Aquafina is no longer active, I forked the repo and posted a release with a built apk file. If you're reading this and are interested in fixing Mokuro image exports on mobile, check it out.

@KamWithK
Copy link
Copy Markdown
Owner

After a small update to the Anki Android API dependency, I managed to build this version and it seems to work well enough to solve the issue raised in #50. Since it seems like Aquafina is no longer active, I forked the repo and posted a release with a built apk file. If you're reading this and are interested in fixing Mokuro image exports on mobile, check it out.

Hey sorry for the late reply, been busy with a new job
This PR involves a large amount of change to the codebase iirc, which isn't necessarily bad but does mean that it needs a more thorough review and test than for most changes/features

If you/others have used this a lot are there any problems, bugs or oddities which you've encountered?

@precondition
Copy link
Copy Markdown

If you/others have used this a lot are there any problems, bugs or oddities which you've encountered?

@KamWithK I'm not sure if it is related yet, but I've noticed that despite setting up a local audio server which works when using the audio button in the Yomitan pop-up, my Anki cards do not pick up the local audio and fall back to the default online JapanesePod server instead. Consequently, all the cards I mine while offline are missing word audio.

Apart from that, adding pictures to my last Anki card via mokuro files works well.

@KamWithK
Copy link
Copy Markdown
Owner

If you/others have used this a lot are there any problems, bugs or oddities which you've encountered?

@KamWithK I'm not sure if it is related yet, but I've noticed that despite setting up a local audio server which works when using the audio button in the Yomitan pop-up, my Anki cards do not pick up the local audio and fall back to the default online JapanesePod server instead. Consequently, all the cards I mine while offline are missing word audio.

Apart from that, adding pictures to my last Anki card via mokuro files works well.

Would you be able to check whether it's actually a problem with this new pr version or whether the latest release also has the same problem for you?

@KamWithK
Copy link
Copy Markdown
Owner

KamWithK commented Mar 9, 2024

If you/others have used this a lot are there any problems, bugs or oddities which you've encountered?

@KamWithK I'm not sure if it is related yet, but I've noticed that despite setting up a local audio server which works when using the audio button in the Yomitan pop-up, my Anki cards do not pick up the local audio and fall back to the default online JapanesePod server instead. Consequently, all the cards I mine while offline are missing word audio.
Apart from that, adding pictures to my last Anki card via mokuro files works well.

Would you be able to check whether it's actually a problem with this new pr version or whether the latest release also has the same problem for you?

@precondition did you ever give that a try?

@naiza-asaad
Copy link
Copy Markdown

naiza-asaad commented Apr 20, 2024

If you/others have used this a lot are there any problems, bugs or oddities which you've encountered?

@KamWithK I'm not sure if it is related yet, but I've noticed that despite setting up a local audio server which works when using the audio button in the Yomitan pop-up, my Anki cards do not pick up the local audio and fall back to the default online JapanesePod server instead. Consequently, all the cards I mine while offline are missing word audio.
Apart from that, adding pictures to my last Anki card via mokuro files works well.

Would you be able to check whether it's actually a problem with this new pr version or whether the latest release also has the same problem for you?

I think I have this issue too on the latest release. When I click on an audio from the popup list, a request like this is called: http://localhost:8765/localaudio/shinmeikai8/media%2F16413.opus

But when I click the add card button, this gets called instead: http://localhost:8765/localaudio/shinmeikai8/media%252F16413.opus

LocalAudioAPIRouting.getAudioHandleError() fails to find the audio in the db for this request. The quickest fix is to decode the path but I guess it's better to look at why Yomitan is sending a different request? why a new request is being made when the audio has already been downloaded?

@KamWithK
Copy link
Copy Markdown
Owner

Given that @Aquafina-water-bottle has been gone for a long while and #60 is in a good state, I'm going to close this PR

@KamWithK KamWithK closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants