Merged
Conversation
…tes() call when possible
Contributor
Author
|
After debugging another bug where the media files in @Twinov @sp3ctum Would appreciate a review whenever y'all have the time! Note that this PR depends on two other (smaller) PRs, so it might be worth taking a look at those first. |
Closed
Owner
|
Going to merge this now as it's been extensively used for ZXY101's mokuro |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges the media logic from
addNoteandupdateNoteFields, i.e. thepicture,audio,videokeys.Depends on #44 and #42