Merged
Conversation
Owner
|
Hey sorry I took so long at this, I thought others had plans to do a PR review but it seems like that isn't going to happen |
Owner
|
FYI, I'm aware you've been awol for a few months on Discord, hoping you're still somewhat active here though |
KamWithK
reviewed
Oct 3, 2023
Owner
KamWithK
left a comment
There was a problem hiding this comment.
Let me know and I'll merge after
app/src/main/java/com/kamwithk/ankiconnectandroid/ankidroid_api/NoteAPI.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Twinov I was playing around with
updateNoteFields, and it seemed to be erroring due to having incorrect fields. This PR should fix it, and actually get the model ID of the note.Note: Was testing the call with
adb shellandcurl