Skip to content

build: make vscode work with PnP#2444

Merged
ylemkimon merged 5 commits intomasterfrom
vscode
Aug 31, 2020
Merged

build: make vscode work with PnP#2444
ylemkimon merged 5 commits intomasterfrom
vscode

Conversation

@ylemkimon
Copy link
Copy Markdown
Member

These files are generated using Editor SDKs.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #2444 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2444   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files          84       84           
  Lines        6112     6112           
  Branches     1254     1254           
=======================================
  Hits         5735     5735           
  Misses        346      346           
  Partials       31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010b267...1ab6dc6. Read the comment docs.

Copy link
Copy Markdown
Member

@k4b7 k4b7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you ran yarn dlx @yarnpkg/pnpify --sdk vscode and then commit the results. Did you have to do anything special for flow?

@ylemkimon
Copy link
Copy Markdown
Member Author

@kevinbarabash I've added flow-for-vscode support to Yarn in yarnpkg/berry#1732, so Yarn needs to be updated before running the command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants