Skip to content

feat(pnpify): add flow-bin to editor SDK#1732

Merged
arcanis merged 2 commits intoyarnpkg:masterfrom
ylemkimon:pnpify-flow
Aug 21, 2020
Merged

feat(pnpify): add flow-bin to editor SDK#1732
arcanis merged 2 commits intoyarnpkg:masterfrom
ylemkimon:pnpify-flow

Conversation

@ylemkimon
Copy link
Copy Markdown
Contributor

@ylemkimon ylemkimon commented Aug 21, 2020

What's the problem this PR addresses?
This PR adds flow-bin to editor SDKs.

How did you fix it?

  • Wrap flow-bin/cli.js and set as flow.pathToFlow for flowtype.flow-for-vscode
  • Add documentation with incompatibility warning (Rendered)

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I have verified that all automated PR checks pass.

@arcanis
Copy link
Copy Markdown
Member

arcanis commented Aug 21, 2020

Hm what's the point of adding a wrapper if it's still incompatible with PnP?

@ylemkimon
Copy link
Copy Markdown
Contributor Author

ylemkimon commented Aug 21, 2020

@arcanis Type checks, local module resolution, and flow-typed still work. Only the external (Node) module resolution doesn't work.

@arcanis
Copy link
Copy Markdown
Member

arcanis commented Aug 21, 2020

Makes sense πŸ‘

@arcanis arcanis merged commit db1cff0 into yarnpkg:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants