Merged
Conversation
|
CLA signature looks good 👍 |
Member
|
@nickkolok thanks for the PR. This should be pretty easy to back port to 0.8.x. I'll have to set up a 0.8.x branch to do the deploy from. I think I'll merge it into master and then back port it afterwards. |
Contributor
Author
|
@kevinbarabash Can I do something to fastenate integration of this PR into |
k4b7
approved these changes
Jan 14, 2018
Member
|
Still need to create a 0.8.x branch and merge this in there. |
Contributor
Author
|
@kevinbarabash I've backported this patch on |
k4b7
pushed a commit
that referenced
this pull request
Jan 22, 2018
* Create a separate entry point for webpack Created a webpack entry point for KaTeX, which imports katex.less. As flow[1] and jest[2] doesn't support CSS modules natively, a separate entry point is used and it is not flowtyped. [1] https://gist.github.com/lambdahands/d19e0da96285b749f0ef [2] https://facebook.github.io/jest/docs/en/webpack.html * Use webpack to build files * Made webpack.config.js export valid webpack configuration * Use: browserify -> webpack babelify -> babel-loader UglifyJS CLI -> UglifyJsPlugin Less CLI -> less-loader cleancss -> cssnano in css-loader build/fonts -> file-loader * Inline CSS(Less) using style-loader and export them using ExtractTextPlugin * Add `watch` npm script calling `webpack --watch` * Improve local testing(webpack-dev-server) * Made webpackDevServer export a valid webpack configuration * Compile Less and inline CSS using less-loader and style-loader * Instead of copying files serve files from /static and use file-loader * Remove old server.js and its dependencies * Use webpack-dev-server in Screenshotter * Include contrib in webpack-dev-server + Moved common configurations to webpack.common.js * Rename webpackDevServer.js to webpack.dev... to be consistent, avoid confusion with webpack-dev-server and follow webpack configuration naming convention. * Remove unnecessary conditional output.path * Use map instead of reduce + Add comments regarding function arguments * Remove unnecessary mkdir and clean build/* before build * Use katex as external dependency instead of global variable in contrib Fixes #692. * Unblock codes as they are built as a module * Update package-lock.json * Add comments regarding devServer option * Lint renamed webpack.dev.js a0d8b33 * Export ES6 module and expose its default export * Revert "Browserify hotfix (#1057)" This reverts commit f6b5091. * Enables colors on the console when running the dev server in Screenshotter * Add context to webpack configuration Allows webpack to be run from other directories * Move `rm -rf build/*` to npm scripts * Check dependencies before build * Move UglifyJsPlugin into config creation * Let webpack handle ES6 modules Do not transform modules to commonjs in Babel. However Jest doesn't not support ES6 modules, so transfrom modules to commonjs when NODE_ENV is `test`. * Add documentation on testing in IE 9 and 10 using webpack-dev-server Changed version range to include IE-compatible version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings from Russia, comrads!
0.8.0and higher are incompatible withbrowserify.0.7.1is compatible.The problem is described in detail here.
I suggest this solution as a hotfix. Real solution should use
standaloneoption as described in a link above.I believe that this PR should be merged into
0.8.xASAP, because otherwise upgrading from0.7.xto0.8.xbreaks any application which useskatexthroughbrowserify.