Bugfixes and enhancements#2629
Bugfixes and enhancements#2629Dunbaratu merged 21 commits intoKSP-KOS:developfrom CharlesOliner:bugfixes-and-enhancements
Conversation
finally tell CKAN that we can handle KSP 1.4.5 just fine
…e number of decimal places.
Dunbaratu
left a comment
There was a problem hiding this comment.
Sorry I took so long to respond to this. Between the apartment fire and being sick, I haven't been operating at my best. I finally got around to it today and had some minor comments. Other than these few minor things I think it looks good and I could merge.
doc/source/math/basic.rst
Outdated
| :func:`CEILING(a)` round up | ||
| :func:`CEILING(a,b)` round up to nearest place | ||
| :func:`FLOOR(a)` round down | ||
| :func:`CEILING(a,b)` round down to nearest place |
There was a problem hiding this comment.
Is this right? Should that be the comment that goes with FLOOR(a,b), not CEILING(a,b)?
| SET myDir TO HEADING(degreesFromNorth, pitchAboveHorizon). | ||
|
|
||
| The third parameter, *roll*, is optional. | ||
|
|
There was a problem hiding this comment.
The sentence above doesn't mention what roll actually does. I think this will have to explain roll by giving examples, since it's otherwise unclear. example: 0 = roof of capsule points at the sky, 180 = roof of capsule points at the ground.
| This creates a new orbit around the Mun:: | ||
|
|
||
| SET myOrbit TO O(0, 0, 270000, 0, 0, 0, 0, Mun). | ||
|
|
There was a problem hiding this comment.
I think we have too many built-ins that are only one letter long like this O(). It gets in the way of people making their own variables. I think we should make this a longer word. Orbit is taken already so maybe neworbit() or createorbit().
Added more details about the new roll argument for HEADING. Renamed the new Orbit constructor O to CREATEORBIT.
|
Thanks for catching those. Is there any way to preview .rst files without
installing Python? (For some reason, nothing related to Python works on my
machine.)
…On Thu, Oct 24, 2019 at 9:02 PM Steven Mading ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Sorry I took so long to respond to this. Between the apartment fire and
being sick, I haven't been operating at my best. I finally got around to it
today and had some minor comments. Other than these few minor things I
think it looks good and I could merge.
------------------------------
In doc/source/math/basic.rst
<#2629 (comment)>:
> :func:`FLOOR(a)` round down
+ :func:`CEILING(a,b)` round down to nearest place
Is this right? Should that be the comment that goes with FLOOR(a,b), not
CEILING(a,b)?
------------------------------
In doc/source/math/direction.rst
<#2629 (comment)>:
>
A :struct:`Direction` can be created out of a :func:`HEADING()` function. The first parameter is the compass heading, and the second parameter is the pitch above the horizon::
SET myDir TO HEADING(degreesFromNorth, pitchAboveHorizon).
+ The third parameter, *roll*, is optional.
+
The sentence above doesn't mention what *roll* actually does. I think
this will have to explain roll by giving examples, since it's otherwise
unclear. example: 0 = roof of capsule points at the sky, 180 = roof of
capsule points at the ground.
------------------------------
In doc/source/structures/orbits/orbit.rst
<#2629 (comment)>:
> +.. function:: O(inc, e, sma, lan, argPe, mEp, t, body)
+
+ :parameter inc: (scalar) inclination
+ :parameter e: (scalar) eccentricity
+ :parameter sma: (scalar) semi-major axis
+ :parameter lan: (scalar) longitude of ascending node
+ :parameter argPe: (scalar) argument of periapsis
+ :parameter mEp: (scalar) mean anomaly at epoch
+ :parameter t: (scalar) epoch
+ :parameter body: (:struct:`Body`) body to orbit around
+ :return: :struct:`Orbit`
+
+ This creates a new orbit around the Mun::
+
+ SET myOrbit TO O(0, 0, 270000, 0, 0, 0, 0, Mun).
+
I think we have too many built-ins that are only one letter long like this
O(). It gets in the way of people making their own variables. I think we
should make this a longer word. Orbit is taken already so maybe neworbit()
or createorbit().
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2629?email_source=notifications&email_token=ACNQ6KJI7WKFK6UQBQRK2U3QQJAS3A5CNFSM4JAKDZR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJFXSRI#pullrequestreview-306936133>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACNQ6KKIVDD676AAUO2UY2DQQJAS3ANCNFSM4JAKDZRQ>
.
|
|
Sadly no - you really need python to run the sphinx scripts. I can't seem to get it to work right on my Windows install at all either (not python, but the rest of the sphinx stuff). I have a remote server with Linux on it where I run them the script generation there. I often don't run it until about to release, which means often releasing includes one more PR where I fix up the minor errors from .RST stuff that didn't parse right, or misspelled links, etc from the last few months. I usually accept RST edits in PRs without testing that they have proper syntax, because I feel confident I can fix them up later while still keeping the meaning right if the author typed all the text but just messed up the formatting syntax. |
Resolves #2613
Resolves #2609
Resolves #2606
Resolves #2599
Resolves #2587
Resolves #2556
Resolves #2530
Added suffixes PARTNER and HASPARTNER to DockingPort, an optional third argument to the heading function, suffix WORDWRAP to Style, a global BODYEXISTS function, optional second arguments to FLOOR and CEILING, and an orbit constructor.
Got rid of startup message about terminal fonts.