Fixes #2488 toggle panels logspam#2504
Merged
Dunbaratu merged 1 commit intoKSP-KOS:developfrom Apr 28, 2019
Merged
Conversation
To fix KSP-KOS#2488 - KSP calls all solar panels "ModuleDeployableSolarPanel" even if they aren't deployable. The only way to tell if it's actually deployable (versus fixed in place) is to see if it had an animation defined. It seems the protection against calling Extend() or Retract() on panels that aren't deployable only existed in the UI where KSP disabled the gui fields if the animation isn't there. That same protection didn't exist in the lower level API, so I had to add the same protections in our code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #2488 - KSP calls all solar panels "ModuleDeployableSolarPanel" even if
they aren't deployable. The only way to tell if it's actually deployable
(versus fixed in place) is to see if it had an animation defined.
It seems the protection against calling Extend() or Retract() on
panels that aren't deployable only existed in the UI where
KSP disabled the gui fields if the animation isn't there.
That same protection didn't exist in the lower level API, so
I had to add the same protections in our code.