update piracies code to support v1.12 changes#334
update piracies code to support v1.12 changes#334lgoettgens merged 3 commits intoJuliaTesting:masterfrom
Conversation
Reflects current status of JuliaLang/julia#58131 PR.
|
Is JuliaLang/julia#58131 still going into 1.12? I am asking this surprised as it is already quite late in the release cycle and that PR doesn't have a backport label. I'll give this a merge once there is a prerelease/nightly build that verifies that in indeed works in action. But for right now, all CI failed due to something with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #334 +/- ##
==========================================
- Coverage 86.93% 86.91% -0.03%
==========================================
Files 11 11
Lines 513 512 -1
==========================================
- Hits 446 445 -1
Misses 67 67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lgoettgens
left a comment
There was a problem hiding this comment.
LGTM, Thanks! I'll re-run CI and merge this once there is a nightly version containing JuliaLang/julia#58131 (in the next two days or so). That way, this patch should already be available when 1.12.0-beta3 gets released
|
The current CI run uses |
(cherry picked from commit d420041)
(cherry picked from commit d420041)
Reflects current status of JuliaLang/julia#58131 PR to remove unnecessary work that is no longer viable.