Some mapreduce improvement#63
Merged
ViralBShah merged 5 commits intoJuliaSparse:mainfrom Jan 17, 2022
N5N3:extrema
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 89.12% 88.99% -0.14%
==========================================
Files 7 7
Lines 5694 5668 -26
==========================================
- Hits 5075 5044 -31
- Misses 619 624 +5
Continue to review full report at Codecov.
|
tkf
reviewed
Jan 16, 2022
Contributor
tkf
left a comment
There was a problem hiding this comment.
LGTM. I think it's ready to be merged once it's clarified at what condition the commented out tests can be enabled.
Should be reverted in future Co-Authored-By: Takafumi Arakaki <takafumi.a@gmail.com>
Contributor
Author
|
Just notice that we'd better enable related change when testing 43604. |
tkf
approved these changes
Jan 16, 2022
Contributor
tkf
left a comment
There was a problem hiding this comment.
LGTM!
@ViralBShah @KristofferC Can you merge this? (Who has the merge bit?)
Member
|
@tkf I've added this repo to the list of repos that committers can write to. You should be able to merge in the future. Thanks. |
tkf
added a commit
to JuliaLang/julia
that referenced
this pull request
Jan 18, 2022
* Define `extrema` using `mapreduce`; support `init` * Fix tests for SparseArrays * API clean and export `extrema!` * Re-implement `reducedim_init` for extrema * Merge `master` to pull in JuliaSparse/SparseArrays.jl#63 * Mark `BigInt` tests as broken Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr> Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com> Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com> Co-authored-by: Tim Holy <tim.holy@gmail.com>
N5N3
added a commit
to N5N3/julia
that referenced
this pull request
Jan 24, 2022
* Define `extrema` using `mapreduce`; support `init` * Fix tests for SparseArrays * API clean and export `extrema!` * Re-implement `reducedim_init` for extrema * Merge `master` to pull in JuliaSparse/SparseArrays.jl#63 * Mark `BigInt` tests as broken Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr> Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com> Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com> Co-authored-by: Tim Holy <tim.holy@gmail.com>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
* Define `extrema` using `mapreduce`; support `init` * Fix tests for SparseArrays * API clean and export `extrema!` * Re-implement `reducedim_init` for extrema * Merge `master` to pull in JuliaSparse/SparseArrays.jl#63 * Mark `BigInt` tests as broken Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr> Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com> Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com> Co-authored-by: Tim Holy <tim.holy@gmail.com>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
* Define `extrema` using `mapreduce`; support `init` * Fix tests for SparseArrays * API clean and export `extrema!` * Re-implement `reducedim_init` for extrema * Merge `master` to pull in JuliaSparse/SparseArrays.jl#63 * Mark `BigInt` tests as broken Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr> Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com> Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com> Co-authored-by: Tim Holy <tim.holy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seperated from JuliaLang/julia#43604.
That PR wants to make
extremarely on ourmapreducemechanism to fixNaN,0.0/-0.0comparison.I tried my best to keep the git histroy for easier review.
Note: This PR included some test change. I guess CI will keep failing there before we merge this. Is there a better way to handle this problem?