Skip to content

Use libsuitesparseconfig from JLL#620

Merged
ViralBShah merged 1 commit intomainfrom
sf/use_jll_library_objects
May 9, 2025
Merged

Use libsuitesparseconfig from JLL#620
ViralBShah merged 1 commit intomainfrom
sf/use_jll_library_objects

Conversation

@staticfloat
Copy link
Copy Markdown
Contributor

@staticfloat staticfloat commented May 6, 2025

This prevents us from being influenced by things like LD_LIBRARY_PATH, and ensures that we always load the correct libsuitesparseconfig that came with our JLL.

@staticfloat
Use libsuitesparseconfig from JLL
a1d6999 
This prevents us from being influenced by things like `LD_LIBRARY_PATH`,
and ensures that we always load the correct `libsuitesparseconfig` that
came with our JLL.
@staticfloat
Copy link
Copy Markdown
Contributor Author

staticfloat commented May 6, 2025

This should fix JuliaInterop/JuliaCall#224

@staticfloat staticfloat added backport 1.10 backport 1.11 backport 1.12 Change should be backported to release-1.12 labels May 6, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.97%. Comparing base (16bbcbc) to head (a1d6999).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/solvers/cholmod.jl 20.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   84.18%   83.97%   -0.22%     
==========================================
  Files          12       12              
  Lines        9265     9265              
==========================================
- Hits         7800     7780      -20     
- Misses       1465     1485      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah ViralBShah merged commit 7b6e810 into main May 9, 2025
11 of 13 checks passed
@ViralBShah ViralBShah deleted the sf/use_jll_library_objects branch May 9, 2025 11:50
@ViralBShah
Copy link
Copy Markdown
Member

ViralBShah commented May 10, 2025 •
edited
Loading

@dkarrasch I've marked various PRs for backporting to 1.12, perhaps a little aggressively. We definitely want this one in so that it fixes some of the R interop issues.

Can I request you to review the list of backports for 1.12 and unmark those you don't agree with? Given that the next beta is almost here, it may be that we only make it into the RC1, but perhaps there is a chance of making into the beta as well.

cc @KristofferC

@dkarrasch dkarrasch removed the backport 1.12 Change should be backported to release-1.12 label May 11, 2025
@dkarrasch
Copy link
Copy Markdown
Member

dkarrasch commented May 11, 2025

The older ones had been already included, but I'm setting up a release-1.12 and a backports-release-1.12 branch.

dkarrasch pushed a commit that referenced this pull request May 11, 2025
@staticfloat @dkarrasch
Use libsuitesparseconfig from JLL (#620)
b38f273 
This prevents us from being influenced by things like `LD_LIBRARY_PATH`,
and ensures that we always load the correct `libsuitesparseconfig` that
came with our JLL.
@dkarrasch dkarrasch mentioned this pull request May 11, 2025
Merged
6 tasks
@IanButterworth
Copy link
Copy Markdown
Contributor

IanButterworth commented May 17, 2025

This appears to have issues

┌ Error: Error during initialization of module CHOLMOD
│   exception =
│    UndefVarError: `libsuitesparseconfig` not defined in `SparseArrays.CHOLMOD`
│    Suggestion: check for spelling errors or missing imports.
│    Hint: a global variable of this name also exists in SuiteSparse_jll.
│    Stacktrace:
│      [1] __init__()
│        @ SparseArrays.CHOLMOD ~/work/SparseArrays.jl/SparseArrays.jl/src/solvers/cholmod.jl:234
│      [2] run_module_init(mod::Module, i::Int64)
│        @ Base ./loading.jl:1416
│      [3] register_restored_modules(sv::Core.SimpleVector, pkg::Base.PkgId, path::String)
│        @ Base ./loading.jl:1404
│      [4] _include_from_serialized(pkg::Base.PkgId, path::String, ocachepath::String, depmods::Vector{Any}; register::Bool)
│        @ Base ./loading.jl:1292
│      [5] _include_from_serialized
│        @ ./loading.jl:[124](https://github.com/JuliaSparse/SparseArrays.jl/actions/runs/14851862331/job/41696854081?pr=620#step:6:127)6 [inlined]
│      [6] _require_search_from_serialized(pkg::Base.PkgId, sourcepath::String, build_id::UInt128, stalecheck::Bool; reasons::Dict{String, Int64}, DEPOT_PATH::Vector{String})
│        @ Base ./loading.jl:2088
│      [7] __require_prelocked(pkg::Base.PkgId, env::String)
│        @ Base ./loading.jl:2600
│      [8] _require_prelocked(uuidkey::Base.PkgId, env::String)
│        @ Base ./loading.jl:2466
│      [9] macro expansion
│        @ ./loading.jl:2394 [inlined]
│     [10] macro expansion
│        @ ./lock.jl:376 [inlined]
│     [11] __require(into::Module, mod::Symbol)
│        @ Base ./loading.jl:2359
│     [12] require
│        @ ./loading.jl:2335 [inlined]
│     [13] eval_import_path(at::Module, from::Nothing, path::Expr, keyword::String)
│        @ Base ./module.jl:35
│     [14] eval_import_path_all(at::Module, path::Expr, keyword::String)
│        @ Base ./module.jl:59
│     [15] _eval_using(to::Module, path::Expr)
│        @ Base ./module.jl:[136](https://github.com/JuliaSparse/SparseArrays.jl/actions/runs/14851862331/job/41696854081?pr=620#step:6:139)
│     [16] top-level scope
│        @ ~/work/SparseArrays.jl/SparseArrays.jl/test/runtests.jl:2
│     [17] include(mapexpr::Function, mod::Module, _path::String)
│        @ Base ./Base.jl:310
│     [18] top-level scope
│        @ none:6
│     [19] eval(m::Module, e::Any)
│        @ Core ./boot.jl:489
│     [20] exec_options(opts::Base.JLOptions)
│        @ Base ./client.jl:297
│     [21] _start()
│        @ Base ./client.jl:564
└ @ SparseArrays.CHOLMOD ~/work/SparseArrays.jl/SparseArrays.jl/src/solvers/cholmod.jl:251

@IanButterworth IanButterworth mentioned this pull request May 17, 2025
Merged
staticfloat added a commit that referenced this pull request May 17, 2025
@staticfloat
fix libsuitesparseconfig bug (#625)
8ff11da 
Fixes
#620 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport 1.10 backport 1.11

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@staticfloat @ViralBShah @dkarrasch @IanButterworth