fixes, debugging, wip on DERelative tests#1774
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1774 +/- ##
===========================================
- Coverage 74.32% 50.32% -24.01%
===========================================
Files 81 80 -1
Lines 5866 5846 -20
===========================================
- Hits 4360 2942 -1418
- Misses 1506 2904 +1398
... and 47 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One issue remains with
solveTreebreaking the result. See broken_tests in this PR. The issue is that although initAll! does good job, the follow-on solve tree with.useMsgLikelihoods=false(over 4 cliques) resets some of the variables to values[0,0], and so:sampleFactortogetSampleinstead (finally able with newCalcFactordesign).some improvements relating to: