Skip to content

Change points to StaticArrays#1713

Merged
Affie merged 5 commits intomasterfrom
23Q2/perf/bitstypes
May 22, 2023
Merged

Change points to StaticArrays#1713
Affie merged 5 commits intomasterfrom
23Q2/perf/bitstypes

Conversation

@Affie
Copy link
Copy Markdown
Member

@Affie Affie commented May 11, 2023

HeatmapSampler test fails repeatedly on github ci, but passes locally. So skipping in this pr with a new issue to fix the test

@Affie Affie self-assigned this May 11, 2023
@Affie Affie added this to the v0.34.0 milestone May 11, 2023
@Affie Affie changed the title hange points to StaticArrays Change points to StaticArrays May 12, 2023
@Affie Affie force-pushed the 23Q2/perf/bitstypes branch from 577d878 to 48c5ea5 Compare May 12, 2023 13:56
@Affie Affie force-pushed the 23Q2/perf/bitstypes branch 2 times, most recently from 1f28711 to 446a5c9 Compare May 22, 2023 08:41
@Affie Affie force-pushed the 23Q2/perf/bitstypes branch from 446a5c9 to bc4726d Compare May 22, 2023 08:58
@codecov
Copy link
Copy Markdown

codecov bot commented May 22, 2023

Codecov Report

Merging #1713 (98444e7) into master (bdb9abe) will decrease coverage by 9.21%.
The diff coverage is 60.34%.

@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
- Coverage   76.55%   67.35%   -9.21%     
==========================================
  Files          74       73       -1     
  Lines        5618     5649      +31     
==========================================
- Hits         4301     3805     -496     
- Misses       1317     1844     +527     
Impacted Files Coverage Δ
src/ConsolidateParametricRelatives.jl 0.00% <0.00%> (-100.00%) ⬇️
src/Deprecated.jl 13.88% <0.00%> (-0.40%) ⬇️
src/Factors/Circular.jl 0.00% <0.00%> (-70.00%) ⬇️
src/Variables/DefaultVariables.jl 100.00% <ø> (ø)
src/services/EvalFactor.jl 77.90% <ø> (-3.73%) ⬇️
src/services/FGOSUtils.jl 72.41% <ø> (ø)
src/ParametricUtils.jl 53.54% <40.00%> (-16.54%) ⬇️
src/ManifoldsExtentions.jl 82.14% <66.66%> (-3.58%) ⬇️
src/services/NumericalCalculations.jl 68.84% <67.39%> (-23.00%) ⬇️

... and 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Affie Affie marked this pull request as ready for review May 22, 2023 11:16
@Affie
Copy link
Copy Markdown
Member Author

Affie commented May 22, 2023

@dehann, I'm merging this as is to try and keep branches from diverging too much.
RoME and IIF tests passes locally, but had to skip one test for CI.

@Affie Affie merged commit e07607a into master May 22, 2023
@dehann dehann modified the milestones: v0.34.0, v0.34.1 Jul 19, 2023
dehann added a commit that referenced this pull request Sep 5, 2023
@Affie Affie deleted the 23Q2/perf/bitstypes branch May 6, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants