Skip to content

defFactorType macro#1077

Merged
Affie merged 5 commits intorefac/factorfrom
24Q2/enh/defFactormacro
Jun 12, 2025
Merged

defFactorType macro#1077
Affie merged 5 commits intorefac/factorfrom
24Q2/enh/defFactormacro

Conversation

@Affie
Copy link
Copy Markdown
Member

@Affie Affie commented Jun 18, 2024 •
edited
Loading

  • Need to still sort out how pack/unpack/convert can work.
    • Design decision is to work with pack / unpack and not convert
  • Rename to defFactorType
  • upstream PackedSamplableBelief

github-actions[bot]
github-actions bot reviewed Jun 18, 2024
View reviewed changes
Comment thread src/services/DFGFactor.jl Outdated
Comment thread src/services/DFGFactor.jl Outdated
Comment thread src/services/DFGFactor.jl Outdated
Comment thread src/services/DFGFactor.jl Outdated
@Affie Affie changed the title defFactorFunction macro defFactorType macro Jul 11, 2024
@Affie Affie self-assigned this Jul 11, 2024
@Affie Affie modified the milestones: v0.24.0, v0.x.0 Jul 11, 2024
This was referenced Feb 25, 2025
Closed
Closed
@Affie Affie mentioned this pull request Mar 28, 2025
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.19%. Comparing base (05ad44d) to head (72f7c39).
Report is 3 commits behind head on refac/factor.

Files with missing lines Patch % Lines
src/services/DFGFactor.jl 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           refac/factor    #1077      +/-   ##
================================================
- Coverage         75.32%   75.19%   -0.13%     
================================================
  Files                28       28              
  Lines              2399     2403       +4     
================================================
  Hits               1807     1807              
- Misses              592      596       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Affie and others added 5 commits June 12, 2025 12:37
@Affie
defFactorFunction macro
422b286
@Affie @github-actions
Apply suggestions from code review
f6fe309 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Affie
update defFactorType
92524ae
@Affie @github-actions
Apply suggestions from code review
fc8923b 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Affie
Update DFGFactor.jl
72f7c39
@Affie Affie force-pushed the 24Q2/enh/defFactormacro branch from 0fc5317 to 72f7c39 Compare June 12, 2025 10:38
@Affie Affie changed the base branch from develop to refac/factor June 12, 2025 10:38
@Affie Affie marked this pull request as ready for review June 12, 2025 10:40
@Affie
Copy link
Copy Markdown
Member Author

Affie commented Jun 12, 2025

Merging to refactor factors branch

@Affie Affie merged commit 3d6c96d into refac/factor Jun 12, 2025
3 checks passed
@Affie Affie mentioned this pull request Jun 17, 2025
Merged
6 tasks
Affie added a commit that referenced this pull request Jun 18, 2025
@Affie
Refactoring Factors: data -> state, observation and cache (#1127)
d8a5695 
* Spike on refactoring Factors

* defFactorType macro (#1077)

* defFactorFunction macro

* update defFactorType

* Update DFGFactor.jl

* Fix tests

* towards consolidated FactorCompute constructor

* Intermediate removing factor solverData

* rm factor data

* rename to AbstractFactorObservation and FactorOperationalMemory -> FactorSolverCache

* fix test and factor solverData related issues

* deprecate GenericFunctionNodeData and related

* fix broken docs

* fix defFactorType -> getManifold

* update news and bump to v0.27

* fix formatting
@Affie Affie modified the milestones: v0.x.0, v0.27.0 Aug 5, 2025
@Affie Affie deleted the 24Q2/enh/defFactormacro branch August 29, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@Affie Affie

Labels

designdecision standardization user experience

Projects

None yet

Milestone

v0.27.0

Development

Successfully merging this pull request may close these issues.

1 participant

@Affie