Decision/Vote: go with state for both variables and factors.
Ticket Acceptance Criteria:
Currently we have the following nouns referring to solver data:
VariableNodeData - Struct
PackedVariableNodeData - Struct
GenericFunctionNodeData - Struct
FunctionNodeData = GenericFunctionNodeData
data - field in FactorDFG
solverData - field in FactorCompute
solverDataDict - field in VariableCompute
solverData - field in VariableDFG
FactorData = PackedFunctionNodeData{InferenceType}
SolverData - Retrieve solver data structure stored in a variable/factor.
VariableSolverData - for get/add etc.
FactorOperationalMemory is also partially in the mix here.
Related:
The observation function is currently part of the factor solver data, see #1119 and #992
Decision/Vote: go with
statefor both variables and factors.Ticket Acceptance Criteria:
datais hard to use, what is better: ?data_fieldhas to do with compute or algorithm mutations that the novice human generally does not mutate.Currently we have the following nouns referring to solver data:
VariableNodeData- StructPackedVariableNodeData- StructGenericFunctionNodeData- StructFunctionNodeData=GenericFunctionNodeDatadata- field in FactorDFGsolverData- field in FactorComputesolverDataDict- field in VariableComputesolverData- field in VariableDFGFactorData=PackedFunctionNodeData{InferenceType}SolverData- Retrieve solver data structure stored in a variable/factor.VariableSolverData- for get/add etc.FactorOperationalMemoryis also partially in the mix here.Related:
The observation function is currently part of the factor solver data, see #1119 and #992