You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Affie and I had a long frustrating conversation to confirm what we already know: That factor data fields need to be updated for DFG 1 milestone. This ticket is the confluence of many other comments including the most recent:
[This issue] Add new field to FactorDFG.observFnc, and replace associated old accessors such as @deprecate getObservationFunction(::FactorDFG) getFactorFunction(::FactorCompute). TAC
spike to check no adverse effect on SDK.rs/c
add new field to FactorDFG.observFnc (side by side with old .data / .fnctype)
@Affie and I had a long frustrating conversation to confirm what we already know: That factor data fields need to be updated for DFG 1 milestone. This ticket is the confluence of many other comments including the most recent:
Context for larger work beyond this issue:
FactorDFG.observFnc, and replace associated old accessors such as@deprecate getObservationFunction(::FactorDFG) getFactorFunction(::FactorCompute).TAC
FactorDFG.observFnc(side by side with old.data / .fnctype)FactorDFG.observFnc_type::StringInvestigate splitting factor operational part from 'constant' part of factor #992getObservationFunction(::FactorDFG)getFactorTypeusegetObservationFunction( DFG or Compute )Additional links from discussion: