Skip to content

Fix typo in partially_inline!#60854

Merged
aviatesk merged 1 commit intomasterfrom
os/fix-claude-found-PR
Jan 29, 2026
Merged

Fix typo in partially_inline!#60854
aviatesk merged 1 commit intomasterfrom
os/fix-claude-found-PR

Conversation

@oscardssmith
Copy link
Copy Markdown
Member

@oscardssmith oscardssmith commented Jan 28, 2026

Found by claude-code debugging a random zygote issue: SciML/NeuralPDE.jl#1020 (comment).

spvals just doesn't exist within this function. This issue has apparently existed since Julia 1.6

Found by claude-code debugging a random zygote issue.
@oscardssmith oscardssmith added bugfix This change fixes an existing bug backport 1.10 Change should be backported to the 1.10 release backport 1.12 Change should be backported to release-1.12 backport 1.13 Change should be backported to release-1.13 labels Jan 28, 2026
This was referenced Jan 28, 2026
Copy link
Copy Markdown
Member

@topolarity topolarity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is so troublesome (poor coverage and no direct users in Base)

Thanks for the fix-up though!

@topolarity topolarity added the merge me PR is reviewed. Merge when all tests are passing label Jan 28, 2026
@aviatesk aviatesk merged commit 94e72bb into master Jan 29, 2026
15 checks passed
@aviatesk aviatesk deleted the os/fix-claude-found-PR branch January 29, 2026 11:10
aviatesk pushed a commit that referenced this pull request Jan 29, 2026
Found by claude-code debugging a random zygote issue:
SciML/NeuralPDE.jl#1020 (comment).

`spvals` just doesn't exist within this function. This issue has
apparently existed since Julia 1.6
aviatesk pushed a commit that referenced this pull request Jan 29, 2026
Found by claude-code debugging a random zygote issue:
SciML/NeuralPDE.jl#1020 (comment).

`spvals` just doesn't exist within this function. This issue has
apparently existed since Julia 1.6
@aviatesk aviatesk mentioned this pull request Jan 29, 2026
43 tasks
@aviatesk aviatesk removed backport 1.12 Change should be backported to release-1.12 backport 1.13 Change should be backported to release-1.13 merge me PR is reviewed. Merge when all tests are passing labels Jan 29, 2026
DilumAluthge pushed a commit that referenced this pull request Jan 30, 2026
Found by claude-code debugging a random zygote issue:
SciML/NeuralPDE.jl#1020 (comment).

`spvals` just doesn't exist within this function. This issue has
apparently existed since Julia 1.6

(cherry picked from commit 94e72bb)
@KristofferC KristofferC removed the backport 1.10 Change should be backported to the 1.10 release label Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This change fixes an existing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants