Skip to content

[1.12] Don't skip CIs from external absints#60741

Merged
DilumAluthge merged 2 commits intobackports-release-1.12from
gb/cache-skip
Jan 20, 2026
Merged

[1.12] Don't skip CIs from external absints#60741
DilumAluthge merged 2 commits intobackports-release-1.12from
gb/cache-skip

Conversation

@gbaraldi
Copy link
Copy Markdown
Member

@gbaraldi gbaraldi commented Jan 19, 2026 •
edited
Loading

Should fix one of the GPUCompiler caching issues

@gbaraldi gbaraldi requested review from vchuravy and vtjnash January 19, 2026 17:58
DilumAluthge
DilumAluthge reviewed Jan 19, 2026
View reviewed changes
gbaraldi and others added 2 commits January 19, 2026 14:23
@gbaraldi @vchuravy @DilumAluthge
[1.12] Don't skip CIs from external absints
b33ce72 
Co-authored-by: Valentin Churavy <vchuravy@mit.edu>
@gbaraldi @DilumAluthge
Update test/precompile_absint2.jl
b567b6c 
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
@DilumAluthge DilumAluthge added the merge me PR is reviewed. Merge when all tests are passing label Jan 19, 2026
@giordano
Copy link
Copy Markdown
Member

giordano commented Jan 19, 2026

Does this need to be forwardported?

@vchuravy vchuravy mentioned this pull request Jan 20, 2026
Merged
@vchuravy
Copy link
Copy Markdown
Member

vchuravy commented Jan 20, 2026

Does this need to be forwardported?

Yes, see #60747

@vchuravy vchuravy mentioned this pull request Jan 20, 2026
Merged
@DilumAluthge DilumAluthge merged commit 13b377a into backports-release-1.12 Jan 20, 2026
8 checks passed
@DilumAluthge DilumAluthge deleted the gb/cache-skip branch January 20, 2026 20:09
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jan 20, 2026
vtjnash
vtjnash reviewed Feb 5, 2026
View reviewed changes
test/precompile_utils.jl
function check_presence(mi, token)
ci = isdefined(mi, :cache) ? mi.cache : nothing
while ci !== nothing
if ci.owner === token && ci.max_world == typemax(UInt)
Copy link
Copy Markdown
Member

@vtjnash vtjnash Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something probably went horribly wrong if ci.max_world != WORLD_AGE_REVALIDATION_SENTINEL, since that means the Compiler made a mistake and forgot to validate it

@maleadt maleadt mentioned this pull request Feb 10, 2026
Closed
@christiangnrd christiangnrd mentioned this pull request Feb 25, 2026
Merged
vchuravy added a commit that referenced this pull request Mar 3, 2026
@vchuravy @gbaraldi @vtjnash
Ensure CI from external MI and foreign abs interpreter survive precom…
e386b48 
…pilation (#60747)

Forward-port of #60741

---------

Co-authored-by: Gabriel Baraldi <baraldigabriel@gmail.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
vchuravy added a commit that referenced this pull request Mar 3, 2026
@vchuravy @gbaraldi @vtjnash
Ensure CI from external MI and foreign abs interpreter survive precom…
cc9e397 
…pilation (#60747)

Forward-port of #60741

---------

Co-authored-by: Gabriel Baraldi <baraldigabriel@gmail.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
(cherry picked from commit e386b48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash vtjnash left review comments

@DilumAluthge DilumAluthge DilumAluthge left review comments

@vchuravy vchuravy vchuravy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gbaraldi @giordano @vchuravy @vtjnash @DilumAluthge