Fix JET warnings in copy_chunks!, copy_chunks_rtol!, fill_chunks!#60453
Merged
Fix JET warnings in copy_chunks!, copy_chunks_rtol!, fill_chunks!#60453
copy_chunks!, copy_chunks_rtol!, fill_chunks!#60453Conversation
00dc201 to
05e6bee
Compare
copy_chunks!, copy_chunks_rtol!, fill_chunks!
> local variable `msk_d1` may be undefined: msk_d1::UInt64 > local variable `msk1` may be undefined: msk1::UInt64
05e6bee to
d8f1167
Compare
aviatesk
approved these changes
Dec 23, 2025
Member
aviatesk
left a comment
There was a problem hiding this comment.
Thanks so much!
and arguably it is now also easier for a human to see that everything is correct.
yeah, I might be a bit biased since I'm the one who enabled this analysis, but I genuinely think the logic has become easier to understand.
aviatesk
pushed a commit
that referenced
this pull request
Dec 23, 2025
…!` (#60453) > local variable `msk_d1` may be undefined: msk_d1::UInt64 The code logic was actually right, but by transforming the code, JET can also see it (and arguably it is now also easier for a human to see that everything is correct)
aviatesk
pushed a commit
that referenced
this pull request
Dec 23, 2025
…!` (#60453) > local variable `msk_d1` may be undefined: msk_d1::UInt64 The code logic was actually right, but by transforming the code, JET can also see it (and arguably it is now also easier for a human to see that everything is correct)
aviatesk
added a commit
that referenced
this pull request
Dec 23, 2025
kpamnany
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jan 16, 2026
…!` (JuliaLang#60453) > local variable `msk_d1` may be undefined: msk_d1::UInt64 The code logic was actually right, but by transforming the code, JET can also see it (and arguably it is now also easier for a human to see that everything is correct)
kpamnany
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jan 21, 2026
…!` (JuliaLang#60453) > local variable `msk_d1` may be undefined: msk_d1::UInt64 The code logic was actually right, but by transforming the code, JET can also see it (and arguably it is now also easier for a human to see that everything is correct)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code logic was actually right, but by transforming the code, JET can also see it (and arguably it is now also easier for a human to see that everything is correct)