[JuliaLowering] Fix handling of unnamed args in @generated functions#60226
Merged
topolarity merged 2 commits intoJuliaLang:masterfrom Nov 24, 2025
Merged
[JuliaLowering] Fix handling of unnamed args in @generated functions#60226topolarity merged 2 commits intoJuliaLang:masterfrom
@generated functions#60226topolarity merged 2 commits intoJuliaLang:masterfrom
Conversation
topolarity
commented
Nov 24, 2025
mlechu
reviewed
Nov 24, 2025
| ] | ||
| [K"call" | ||
| "svec"::K"core" | ||
| (n.name_val::K"Symbol"(n) for n in typevar_names)... |
Member
There was a problem hiding this comment.
Do we need this for static parameters too? (Underscores are usable as static parameters, but is that even intended?)
Member
Author
There was a problem hiding this comment.
Good question! I'd say this is probably unintended:
julia> foo(x::_, y::_) where _ = 13
foo (generic function with 1 method)
julia> foo(1,2)
13
julia> foo(1,2.4)
ERROR: MethodError: no method matching foo(::Int64, ::Float64)
The function `foo` exists, but no method is defined for this combination of argument types.
Closest candidates are:
foo(::_, ::_) where _that should probably be an error, just like foo(::_, ::_) = ... is
mlechu
reviewed
Nov 24, 2025
96b2ec4 to
1e1c10e
Compare
This is required to get Dates pre-compiling with JuliaLowering.
1e1c10e to
47c6271
Compare
mlechu
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to get Dates pre-compiling with JuliaLowering.