avoid overflow when inline_cost_threshold == typemax(Int)#60121
Open
simeonschaub wants to merge 2 commits intomasterfrom
Open
avoid overflow when inline_cost_threshold == typemax(Int)#60121simeonschaub wants to merge 2 commits intomasterfrom
inline_cost_threshold == typemax(Int)#60121simeonschaub wants to merge 2 commits intomasterfrom
Conversation
GPUCompiler will set `inline_cost_threshold` to `typemax(Int)` as a way to force inlining, make sure this doesn't cause integer overflow. should fix JuliaGPU/AMDGPU.jl#846
Member
|
I would probably argue that setting a threshold so high that math doesn't work on it probably isn't a great idea (e.g. maybe set it to a couple billion instead since no GPU can compile that much code into a kernel?) |
simeonschaub
added a commit
to JuliaGPU/GPUCompiler.jl
that referenced
this pull request
Nov 14, 2025
as cost threshold for `always_inline` to avoid integer overflow fix JuliaGPU/AMDGPU.jl#846 alternative to JuliaLang/julia#60121
This was referenced Jan 9, 2026
Merged
71 tasks
56 tasks
Member
|
seems like it would be more principled to used checked arithmetic (maybe saturating is better in this context actually?) in |
This was referenced Feb 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPUCompiler will set
inline_cost_thresholdtotypemax(Int)as a way to force inlining, make sure this doesn't cause integer overflow.should fix JuliaGPU/AMDGPU.jl#846