Avoid hardcoding paths in Profile and Sys#59998
Merged
Conversation
Current code fails when using custom paths. Save directory where Julia source is stored during build in `SOURCEDIR` instead of assuming it can be computed from `BINDIR` (new name chosen to avoid confusing with `build_dir` which is different). Use `DATAROOTDIR` and `DATAROOT` instead of hardcoding `usr/share/` and `share/`. Fix/continuation of #56601, #56627.
nalimilan
commented
Oct 30, 2025
base/Makefile
Outdated
| @printf "%s\n" "const PRIVATE_LIBDIR = "$(call shell_escape,$(call julia_escape,$(call normalize_path,$(private_libdir_rel)))) >> $@ | ||
| @printf "%s\n" "const PRIVATE_LIBEXECDIR = "$(call shell_escape,$(call julia_escape,$(call normalize_path,$(private_libexecdir_rel)))) >> $@ | ||
| @printf "%s\n" "const INCLUDEDIR = "$(call shell_escape,$(call julia_escape,$(call normalize_path,$(includedir_rel)))) >> $@ | ||
| @printf "%s\n" "const SOURCEDIR = "$(call shell_escape,$(call julia_escape,$(call normalize_path,$(JULIAHOME)))) >> $@ |
Member
Author
There was a problem hiding this comment.
AFAICT this new constant is needed as paths to source files are those at build time. BUILD_ROOT_PATH which was defined below was incorrect in claiming that it pointed to the build-time source path as it was based on BINDIR, yet there's no guarantee that the julia executable during build time is next to the source dir.
Failure for `@juliasrc`: SOURCEDIR was "/c/workdir" (giving "\\c\\workdir") on Windows builder, while "C:\\workdir" was expected. Failure for `@Compiler`: missing ending slash meant that remainder was an absolute path. Minor cleanups.
Member
Author
|
CI failure on test x86_64-linux-gnuassertrr seems unrelated. |
IanButterworth
approved these changes
Nov 2, 2025
17 tasks
Member
Author
|
Thanks @IanButterworth. Do you want to double-check this @KristofferC? These issues are so tricky that another pair of eyes wouldn't hurt... |
Member
|
I see fewer hardcoded paths so that is nice. Should the stuff in #57274 be updated as well? |
Member
Author
|
I think it's correct as with the current options stdlib and Compiler will always live under This partly overlaps with #54353 which I'm trying to finish but I get some errors that I haven't been able to fix yet. |
KristofferC
approved these changes
Nov 7, 2025
Member
KristofferC
left a comment
There was a problem hiding this comment.
Nice, LGTM (assuming CI is ok)
Member
Author
|
Thanks! |
KristofferC
pushed a commit
that referenced
this pull request
Nov 10, 2025
Current code fails when using custom paths. Save directory where Julia source is stored during build in `SOURCEDIR` instead of assuming it can be computed from `BINDIR` (new name chosen to avoid confusing with `build_dir` which is different). Use `DATAROOTDIR` and `DATAROOT` instead of hardcoding `usr/share/` and `share/`. Fix/continuation of #56601, #56627. (cherry picked from commit b60d1db)
KristofferC
pushed a commit
that referenced
this pull request
Nov 11, 2025
Current code fails when using custom paths. Save directory where Julia source is stored during build in `SOURCEDIR` instead of assuming it can be computed from `BINDIR` (new name chosen to avoid confusing with `build_dir` which is different). Use `DATAROOTDIR` and `DATAROOT` instead of hardcoding `usr/share/` and `share/`. Fix/continuation of #56601, #56627. (cherry picked from commit b60d1db)
topolarity
added a commit
that referenced
this pull request
Nov 12, 2025
I'm not sure why this removal was necessary, but deleting this binding messes up Profile's ability to identity build paths for `@Compiler/` etc. as of #59998
topolarity
added a commit
that referenced
this pull request
Nov 13, 2025
Deleting this binding messes up Profile's ability to identity build paths for `@Compiler/` etc. as of #59998
topolarity
added a commit
that referenced
this pull request
Nov 14, 2025
Deleting this binding messes up Profile's ability to identity build paths for `@Compiler/` etc. as of #59998
IanButterworth
pushed a commit
to IanButterworth/julia
that referenced
this pull request
Nov 30, 2025
Current code fails when using custom paths. Save directory where Julia source is stored during build in `SOURCEDIR` instead of assuming it can be computed from `BINDIR` (new name chosen to avoid confusing with `build_dir` which is different). Use `DATAROOTDIR` and `DATAROOT` instead of hardcoding `usr/share/` and `share/`. Fix/continuation of JuliaLang#56601, JuliaLang#56627.
IanButterworth
pushed a commit
that referenced
this pull request
Nov 30, 2025
Current code fails when using custom paths. Save directory where Julia source is stored during build in `SOURCEDIR` instead of assuming it can be computed from `BINDIR` (new name chosen to avoid confusing with `build_dir` which is different). Use `DATAROOTDIR` and `DATAROOT` instead of hardcoding `usr/share/` and `share/`. Fix/continuation of #56601, #56627.
KristofferC
pushed a commit
that referenced
this pull request
Dec 16, 2025
Current code fails when using custom paths. Save directory where Julia source is stored during build in `SOURCEDIR` instead of assuming it can be computed from `BINDIR` (new name chosen to avoid confusing with `build_dir` which is different). Use `DATAROOTDIR` and `DATAROOT` instead of hardcoding `usr/share/` and `share/`. Fix/continuation of #56601, #56627.
kpamnany
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jan 21, 2026
Current code fails when using custom paths. Save directory where Julia source is stored during build in `SOURCEDIR` instead of assuming it can be computed from `BINDIR` (new name chosen to avoid confusing with `build_dir` which is different). Use `DATAROOTDIR` and `DATAROOT` instead of hardcoding `usr/share/` and `share/`. Fix/continuation of JuliaLang#56601, JuliaLang#56627.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current code fails when using custom paths. Save directory where Julia source is stored during build in
SOURCEDIRinstead of assuming it can be computed fromBINDIR(new name chosen to avoid confusing withbuild_dirwhich is different). UseDATAROOTDIRandDATAROOTinstead of hardcodingusr/share/andshare/.Fix/continuation of #56601, #56627.