Skip to content

[NFC] add tests for typemin power of float#59745

Merged
adienes merged 1 commit intoJuliaLang:masterfrom
adienes:float_typemin_exp_tests
Oct 5, 2025
Merged

[NFC] add tests for typemin power of float#59745
adienes merged 1 commit intoJuliaLang:masterfrom
adienes:float_typemin_exp_tests

Conversation

@adienes
Copy link
Copy Markdown
Member

@adienes adienes commented Oct 5, 2025 •
edited
Loading

with backports, as suggested in #57463 (comment). closes #57463

@adienes adienes added test This change adds or pertains to unit tests maths Mathematical functions backport 1.10 Change should be backported to the 1.10 release backport 1.12 Change should be backported to release-1.12 labels Oct 5, 2025
@adienes adienes merged commit 30c34ef into JuliaLang:master Oct 5, 2025
11 of 13 checks passed
@adienes adienes deleted the float_typemin_exp_tests branch October 5, 2025 21:30
KristofferC pushed a commit that referenced this pull request Oct 6, 2025
@adienes
[NFC] add tests for typemin power of float (#59745)
5f44496 
with backports, as suggested in
#57463 (comment).
closes #57463

(cherry picked from commit 30c34ef)
@KristofferC KristofferC mentioned this pull request Oct 6, 2025
Merged
47 tasks
KristofferC pushed a commit that referenced this pull request Oct 12, 2025
@adienes @KristofferC
[NFC] add tests for typemin power of float (#59745)
ed983cd 
with backports, as suggested in
#57463 (comment).
closes #57463

(cherry picked from commit 30c34ef)
KristofferC pushed a commit that referenced this pull request Oct 14, 2025
@adienes @KristofferC
[NFC] add tests for typemin power of float (#59745)
6c28ba0 
with backports, as suggested in
#57463 (comment).
closes #57463

(cherry picked from commit 30c34ef)
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Oct 21, 2025
@KristofferC KristofferC mentioned this pull request Nov 20, 2025
Merged
@KristofferC KristofferC mentioned this pull request Dec 12, 2025
Merged
@KristofferC KristofferC mentioned this pull request Jan 3, 2026
Merged
DilumAluthge pushed a commit that referenced this pull request Jan 19, 2026
@adienes @DilumAluthge
[NFC] add tests for typemin power of float (#59745)
065d574 
with backports, as suggested in
#57463 (comment).
closes #57463

(cherry picked from commit 30c34ef)
@DilumAluthge DilumAluthge mentioned this pull request Jan 19, 2026
Merged
71 tasks
DilumAluthge pushed a commit that referenced this pull request Jan 20, 2026
@adienes @DilumAluthge
[NFC] add tests for typemin power of float (#59745)
d7a3b1d 
with backports, as suggested in
#57463 (comment).
closes #57463

(cherry picked from commit 30c34ef)
@DilumAluthge
Copy link
Copy Markdown
Member

DilumAluthge commented Jan 28, 2026

I see that this has been backported to 1.10. Unfortunately, the tests are failing on the tip of backports-release-1.10 (#58889).

Is there some other PR that needs to also backported to 1.10, in order to get these tests to pass?

Or alternatively, can I remove this from the 1.10 backports branch?

@adienes
Copy link
Copy Markdown
Member Author

adienes commented Jan 28, 2026 •
edited
Loading

that's a bit confusing, since #53967 was backported to 1.10, no? was there some regression in a 1.10 patch version?

@DilumAluthge
Copy link
Copy Markdown
Member

DilumAluthge commented Jan 28, 2026

that's a bit confusing, since #53967 was backported to 1.10, no?

So, #53967 landed on the 1.10.10 backports PR as ee8dd0f, but then it was reverted in 7f6ffc7.

@DilumAluthge
Copy link
Copy Markdown
Member

DilumAluthge commented Jan 28, 2026

I can try to re-land #53967 onto 1.10.

@DilumAluthge
Copy link
Copy Markdown
Member

DilumAluthge commented Jan 28, 2026

Is #53967 the only PR that needs to be backported in order to make these tests pass on 1.10?

@adienes
Copy link
Copy Markdown
Member Author

adienes commented Jan 28, 2026

I think so, but it might not be worth the hassle to revert the revert. IMO this is not a showstopper bug..

@DilumAluthge
Copy link
Copy Markdown
Member

DilumAluthge commented Jan 28, 2026

I tried it out locally, and it seems like my re-land has fixed the tests in question. Let's see if CI agrees.

If CI is unhappy, or if PkgEval is unhappy, then I'll remove my re-land, and I'll also remove the backport of the tests from this PR.

@DilumAluthge
Copy link
Copy Markdown
Member

DilumAluthge commented Jan 29, 2026 •
edited
Loading

#53967 fixes the tests in this PR (@test iszero(1.1^typemin(T)), etc) but introduces a new test failure of the form: (example CI log)

Error in testset numbers:
Error During Test at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-10/julia-5982ccd0ad/share/julia/test/numbers.jl:2543
  Got exception outside of a @test
  InexactError: check_top_bit(UInt64, -9223372036854775808)
  Stacktrace:

I'll remove #53967 from the 1.10 backports PR, and I'll also remove this PR (#59745).

@DilumAluthge DilumAluthge removed the backport 1.10 Change should be backported to the 1.10 release label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oscardssmith oscardssmith oscardssmith approved these changes

Assignees

No one assigned

Labels

maths Mathematical functions test This change adds or pertains to unit tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Float64 raised to an integer's typemin produces incorrect result

4 participants

@adienes @DilumAluthge @oscardssmith @KristofferC