improve inferred effects for reshape for Array#58672
Merged
IanButterworth merged 1 commit intoJuliaLang:masterfrom Jun 9, 2025
Merged
improve inferred effects for reshape for Array#58672IanButterworth merged 1 commit intoJuliaLang:masterfrom
reshape for Array#58672IanButterworth merged 1 commit intoJuliaLang:masterfrom
Conversation
Contributor
|
Hello! I am a bot. Thank you for your pull request! I have assigned
Note: If you are a Julia committer, please make sure that your organization membership is public. |
f25cfd7 to
7381e22
Compare
Member
Author
|
FTR: the force push just added a |
Member
Author
|
Before: julia> VERSION
v"1.13.0-DEV.720"
julia> Base.infer_effects(reshape, Tuple{Vector{Float32}, Tuple{Int}})
(!c,!e,!n,!t,!s,!m,!u,+o,!r)
julia> Base.infer_effects(reshape, Tuple{Matrix{Float32}, Tuple{Int}})
(!c,!e,!n,!t,!s,!m,!u,+o,!r)
julia> Base.infer_effects(reshape, Tuple{Vector{Float32}, Tuple{Int, Int}})
(!c,!e,!n,!t,!s,!m,!u,+o,!r)
julia> Base.infer_effects(reshape, Tuple{Matrix{Float32}, Tuple{Int, Int}})
(!c,!e,!n,!t,!s,!m,!u,+o,!r)After: julia> VERSION
v"1.13.0-DEV.721"
julia> Base.infer_effects(reshape, Tuple{Vector{Float32}, Tuple{Int}})
(?c,+e,!n,+t,+s,?m,+u,+o,+r)
julia> Base.infer_effects(reshape, Tuple{Matrix{Float32}, Tuple{Int}})
(?c,+e,!n,+t,+s,?m,+u,+o,+r)
julia> Base.infer_effects(reshape, Tuple{Vector{Float32}, Tuple{Int, Int}})
(?c,+e,!n,+t,+s,?m,+u,+o,+r)
julia> Base.infer_effects(reshape, Tuple{Matrix{Float32}, Tuple{Int, Int}})
(?c,+e,!n,+t,+s,?m,+u,+o,+r) |
oscardssmith
reviewed
Jun 9, 2025
Use `LazyString` in `throw_dmrsa`.
bd8f634 to
c78e984
Compare
oscardssmith
approved these changes
Jun 9, 2025
KristofferC
pushed a commit
that referenced
this pull request
Jun 11, 2025
nilesh646
pushed a commit
to nilesh646/julia
that referenced
this pull request
Jun 17, 2025
60 tasks
jishnub
added a commit
to JuliaArrays/FillArrays.jl
that referenced
this pull request
Nov 6, 2025
Based on #419 since `LazyString` and `lazy"..."` are only available in Julia >= 1.8. --- The PR changes all error messages to lazy strings to delay string interpolation and `print`ing of the involved quantities until the error message is displayed (and hence skip it completely if the error path is not hit). Using `LazyString`s in error messages generally also helps with type inference (see e.g. JuliaLang/julia#58672 and JuliaLang/julia#54737). --------- Co-authored-by: Jishnu Bhattacharya <jishnub.github@gmail.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
LazyStringinthrow_dmrsa.