Skip to content

CI: PrAssignee.yml: Skip BumpStdlibs.jl PRs (PRs authored by @DilumAluthgeBot)#58625

Merged
DilumAluthge merged 5 commits intomasterfrom
dpa/skip-da-bot
Jun 6, 2025
Merged

CI: PrAssignee.yml: Skip BumpStdlibs.jl PRs (PRs authored by @DilumAluthgeBot)#58625
DilumAluthge merged 5 commits intomasterfrom
dpa/skip-da-bot

Conversation

@DilumAluthge
Copy link
Copy Markdown
Member

@DilumAluthge DilumAluthge commented Jun 3, 2025 •
edited
Loading

Hat-tip to @IanButterworth for reporting this.

@DilumAluthge DilumAluthge added ci Continuous integration github-actions labels Jun 3, 2025
@DilumAluthge
Copy link
Copy Markdown
Member Author

DilumAluthge commented Jun 3, 2025

Let's hold off on reviewing this PR until we have merged #58612.

Then I'll rebase this PR.

Otherwise we'll probably end up with merge conflicts.

Base automatically changed from dpa/triage to master June 3, 2025 22:50
@LilithHafner
Copy link
Copy Markdown
Member

LilithHafner commented Jun 3, 2025

This PR is okay, but I think we can do the same functionality with a much smaller diff & shorter implementation, if that matters to you.

@DilumAluthge
Copy link
Copy Markdown
Member Author

DilumAluthge commented Jun 3, 2025

What did you have in mind?

@DilumAluthge
Copy link
Copy Markdown
Member Author

DilumAluthge commented Jun 3, 2025

We could just push DilumAluthgeBot onto the allCollaboratorsFlattened list - was that what you were thinking?

@LilithHafner
Copy link
Copy Markdown
Member

LilithHafner commented Jun 4, 2025

Yeah, that way we don't have to duplicate the nested if clause

@DilumAluthge DilumAluthge marked this pull request as ready for review June 6, 2025 03:41
DilumAluthge added a commit that referenced this pull request Jun 6, 2025
@DilumAluthge
Test for #58625 (PR from committer)
c2599ba
@DilumAluthge
Copy link
Copy Markdown
Member Author

DilumAluthge commented Jun 6, 2025

Here's a test PR for the "PR author is committer" code path:

That test PR seems to have worked correctly.

@LilithHafner Can you open a test PR against this branch (dpa/skip-da-bot) from @LilithHafnerBot? We can no longer use @DilumAluthgeBot to test the non-committer code path.

DilumAluthgeBot added a commit to DilumAluthgeBot/julia that referenced this pull request Jun 6, 2025
@DilumAluthgeBot
Test for JuliaLang#58625 (PR from DABot)
3f569a6
DilumAluthgeBot added a commit to DilumAluthgeBot/julia that referenced this pull request Jun 6, 2025
@DilumAluthgeBot
Test for JuliaLang#58625 (PR from DABot)
88ad016
@DilumAluthge
Copy link
Copy Markdown
Member Author

DilumAluthge commented Jun 6, 2025

Also, here is a test PR from @DilumAluthgeBot:

The "PR assignee" was skipped on that PR, which is the desired behavior - it means that BumpStdlibs.jl PRs will be skipped.

@DilumAluthge
Copy link
Copy Markdown
Member Author

DilumAluthge commented Jun 6, 2025

@LilithHafner We likely also need to skip Dependabot PRs: #58657

@DilumAluthge DilumAluthge merged commit 67b69dd into master Jun 6, 2025
3 of 7 checks passed
@DilumAluthge DilumAluthge deleted the dpa/skip-da-bot branch June 6, 2025 18:05
nilesh646 pushed a commit to nilesh646/julia that referenced this pull request Jun 17, 2025
@DilumAluthge @LilithHafner @nilesh646
CI: PrAssignee.yml: Skip BumpStdlibs.jl PRs (PRs authored by `@Dilu…
f89c2e6 
…mAluthgeBot`) (JuliaLang#58625)

Hat-tip to `@IanButterworth` for reporting this.

---------

Co-authored-by: Lilith Orion Hafner <lilithhafner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LilithHafner LilithHafner LilithHafner approved these changes

Assignees

No one assigned

Labels

ci Continuous integration github-actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DilumAluthge @LilithHafner