Skip to content

Fix linearize of global with complex type#58611

Merged
KristofferC merged 1 commit intoJuliaLang:masterfrom
mlechu:fix-58609
Jun 3, 2025
Merged

Fix linearize of global with complex type#58611
KristofferC merged 1 commit intoJuliaLang:masterfrom
mlechu:fix-58609

Conversation

@mlechu
Copy link
Copy Markdown
Member

@mlechu mlechu commented Jun 2, 2025

Lowering assumes (globaldecl x y) has a simple y, but this is not always the case, e.g. global x::T where T. Broke in #54773, fixes #58609

@mlechu mlechu requested a review from Keno June 2, 2025 21:59
@mlechu mlechu added the compiler:lowering Syntax lowering (compiler front end, 2nd stage) label Jun 2, 2025
@mlechu mlechu changed the title Fix linearize of global with with complex type Fix linearize of global with complex type Jun 2, 2025
@KristofferC KristofferC merged commit 050284c into JuliaLang:master Jun 3, 2025
11 checks passed
KristofferC pushed a commit that referenced this pull request Jun 3, 2025
@oscardssmith
Copy link
Copy Markdown
Member

Does this need a 1.12 backport?

@KristofferC KristofferC added the backport 1.12 Change should be backported to release-1.12 label Jun 3, 2025
@KristofferC
Copy link
Copy Markdown
Member

(yes, I already backported it manually but it should have the label)

@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler:lowering Syntax lowering (compiler front end, 2nd stage)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"syntax: internal bug: ssavalue with no def" in some packages in PkgEval

4 participants