Conversation
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
|
I took it off the milestone and slapped a "merge me" on it, but once merged we should make a milestone item to turn those |
| use_stale(c) = stale(c[1]) + not_stale("hello") | ||
| build_stale(x) = use_stale(Any[x]) | ||
|
|
||
| # bindings |
There was a problem hiding this comment.
tests for this code path are mostly in rebinding.jl. I don't really mind it being here, but I don't fully know yet what distinguishes this case from the ones already tested
There was a problem hiding this comment.
Thanks, I hadn't found that yet. Likewise I'd have no objection to moving these tests to rebinding.jl.
There was a problem hiding this comment.
One potential difference: from a quick scan, the tests in rebinding.jl seem to define the function in the same module in which it's precompiled. This test defines StaleA.fib() but defers its precompilation until StaleB, and yanks the rug out in between loading those two modules.
This adds a test for an invalidation failure when `consts` are redefined. The failure occurs only in "edge" mode, i.e., due to the separation of precompilation from the user's running session.
This adds a test for an invalidation failure when `consts` are redefined. The failure occurs only in "edge" mode, i.e., due to the separation of precompilation from the user's running session. (cherry picked from commit c13ea2b)
This adds a test for an invalidation failure when
constsare redefined. The failure occurs only in "edge" mode, i.e., due to the separation of precompilation from the user's running session.The corresponding "immediate" sequence is the following (which seems to work properly):
But it fails when the precompilation of
fibhappens in a package that gets loaded aftergibis redefined in the user's session.