Base: PCRE: exec: type assert String after construction#57868
Merged
KristofferC merged 1 commit intoJuliaLang:masterfrom Mar 25, 2025
Merged
Base: PCRE: exec: type assert String after construction#57868KristofferC merged 1 commit intoJuliaLang:masterfrom
Base: PCRE: exec: type assert String after construction#57868KristofferC merged 1 commit intoJuliaLang:masterfrom
Conversation
Should prevent some invalidation in the sysimage.
Member
Author
|
Reduces the invalidation count on running ./julia -E 'using SnoopCompileCore; i = (@snoop_invalidations (struct I <: Integer end; Base.UInt(::I) = 0x7)); using SnoopCompile; length(uinvalidated(i))'Prevents these specific invalidations: {
"method_instance": {
"method": "_exec(re, subject, offset, options, match_data) @ Base.PCRE pcre.jl:204",
"method_instance": "MethodInstance for Base.PCRE._exec(::Ptr{Nothing}, ::Any, ::Int64, ::UInt32, ::Ptr{Nothing})"
},
"children": [
{
"method_instance": {
"method": "exec(re, subject, offset, options, match_data) @ Base.PCRE pcre.jl:201",
"method_instance": "MethodInstance for Base.PCRE.exec(::Ptr{Nothing}, ::Any, ::Int64, ::UInt32, ::Ptr{Nothing})"
},
"children": [
{
"method_instance": {
"method": "exec_r(re, subject, offset, options) @ Base.PCRE pcre.jl:213",
"method_instance": "MethodInstance for Base.PCRE.exec_r(::Ptr{Nothing}, ::Any, ::Int64, ::UInt32)"
},
"children": [
{
"method_instance": {
"method": "var\"#occursin#463\"(offset::Integer, ::typeof(occursin), r::Regex, s::AbstractString) @ Base regex.jl:306",
"method_instance": "MethodInstance for Base.var\"#occursin#463\"(::Int64, ::typeof(occursin), ::Regex, ::AbstractString)"
},
"children": [
{
"method_instance": {
"method": "occursin(r::Regex, s::AbstractString; offset) @ Base regex.jl:306",
"method_instance": "MethodInstance for occursin(::Regex, ::AbstractString)"
},
"children": [
{
"method_instance": {
"method": "url(m::Method) @ Base methodshow.jl:378",
"method_instance": "MethodInstance for Base.url(::Method)"
},
"children": [
]
}
]
}
]
}
]
}
]
}
]
} |
KristofferC
pushed a commit
that referenced
this pull request
Mar 26, 2025
KristofferC
pushed a commit
that referenced
this pull request
Mar 31, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should prevent some invalidation in the sysimage.