Fix package precompilation (PrecompileTools)#57828
Merged
JeffBezanson merged 2 commits intomasterfrom Mar 20, 2025
Merged
Conversation
With the "classic" inference timing disabled, PrecompileTools and SnoopCompile are non-functional on 1.12 & master. #57074 added timing data to the CodeInstances themselves, which should help restore SnoopCompile. However, without the tree structure provided by the old inference timing system, we still need a way to tag MethodInstances that get inferred inside `PrecompileTools.@compile_workload` blocks. This adds a simple mechanism modeled after `@trace_compile` that switching to tagging MethodInstances in `jl_push_newly_inferred`. JuliaLang/PrecompileTools.jl#47 contains the corresponding changes to PrecompileTools.jl.
vtjnash
approved these changes
Mar 19, 2025
Member
|
Will Pkg's internalized https://github.com/JuliaLang/Pkg.jl/blob/master/src/precompile.jl#L217-L244 |
Member
Author
|
Yes, I'll push a very simple test in the next commit. (PrecompileTools is a test of sorts, but good to have one here too.) |
Member
Author
|
Corresponding changes in JuliaLang/PrecompileTools.jl#47 are now up too |
Member
|
I just noticed that #54899 deleted the corresponding internalized Shall we make a barebones version for Base so that we're not duplicating code between Pkg and REPL and any other stdlibs that want to benefit? |
Member
|
I deleted it there because I noticed it seemed to be making the quality of the REPL script worse not better |
KristofferC
pushed a commit
that referenced
this pull request
Mar 20, 2025
With the "classic" inference timing disabled, PrecompileTools and SnoopCompile are non-functional on 1.12 & master. #57074 added timing data to the CodeInstances themselves, which should help restore SnoopCompile. However, without the tree structure provided by the old inference timing system, we still need a way to tag MethodInstances that get inferred inside `PrecompileTools.@compile_workload` blocks. This adds a simple mechanism modeled after `@trace_compile` that switches to tagging MethodInstances in `jl_push_newly_inferred`. JuliaLang/PrecompileTools.jl#47 contains (or will contain) the corresponding changes to PrecompileTools.jl. (cherry picked from commit c89b1ff)
vchuravy
reviewed
Mar 24, 2025
| // Mutex for newly_inferred | ||
| jl_mutex_t newly_inferred_mutex; | ||
| extern jl_mutex_t world_counter_lock; | ||
| static _Atomic(uint8_t) jl_tag_newly_inferred_enabled = 0; |
Member
There was a problem hiding this comment.
This could just be a UInt64 since we are using a whole cache line anyways
vchuravy
added a commit
that referenced
this pull request
Oct 16, 2025
REPL precompile scripts runs a workload and might thus encounter code in other standard libraries that needs to be precompiled. Before #54899 we had a bespoke variant of PrecompileTools.jl. PrecompileTools was fixed with #57828 so we can now re-instate the support in REPL. Noticed by @tecosaur, while looking at #51811
KristofferC
pushed a commit
that referenced
this pull request
Oct 16, 2025
REPL precompile scripts runs a workload and might thus encounter code in other standard libraries that needs to be precompiled. Before #54899 we had a bespoke variant of PrecompileTools.jl. PrecompileTools was fixed with #57828 so we can now re-instate the support in REPL. Noticed by @tecosaur, while looking at #51811 (cherry picked from commit ecfec85)
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the "classic" inference timing disabled, PrecompileTools and SnoopCompile are non-functional on 1.12 & master. #57074 added timing data to the CodeInstances themselves, which should help restore SnoopCompile. However, without the tree structure provided by the old inference timing system, we still need a way to tag MethodInstances that get inferred inside
PrecompileTools.@compile_workloadblocks.This adds a simple mechanism modeled after
@trace_compilethat switches to tagging MethodInstances injl_push_newly_inferred. JuliaLang/PrecompileTools.jl#47 contains (or will contain) the corresponding changes to PrecompileTools.jl.