relax some doctests to better match non-requirement of ordering of Dict and Set#57693
Merged
oscardssmith merged 4 commits intoJuliaLang:masterfrom Mar 25, 2025
Merged
relax some doctests to better match non-requirement of ordering of Dict and Set#57693oscardssmith merged 4 commits intoJuliaLang:masterfrom
Dict and Set#57693oscardssmith merged 4 commits intoJuliaLang:masterfrom
Conversation
Member
Author
|
look ok? |
jakobnissen
suggested changes
Mar 13, 2025
Member
Author
|
@jakobnissen I tried to narrow the filters a bit --- concretely that meant changing a few I do think though as a general rule of thumb I would design doctests to be looser than optimal rather than stricter, since they will never be able to be as comprehensive / accurate as dedicated unit tests. |
Member
|
That's fair. You're right, doctests are mostly meant to ensure the code runs (although having them work as actual tests is of course nice, where possible) |
jakobnissen
approved these changes
Mar 16, 2025
Member
Author
|
if this looks ok, a merge would make CI more friendly on #57509 |
Member
Author
|
bump |
LebedevRI
pushed a commit
to LebedevRI/julia
that referenced
this pull request
May 2, 2025
… ordering of Dict and Set" (JuliaLang#58053) I missed a few of these in the initial PR here JuliaLang#57693 hopefully there aren't any more...
charleskawczynski
pushed a commit
to charleskawczynski/julia
that referenced
this pull request
May 12, 2025
… ordering of Dict and Set" (JuliaLang#58053) I missed a few of these in the initial PR here JuliaLang#57693 hopefully there aren't any more...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
discovered during failure of doctests in #57509 but is an independent change