Disallow non-lhs all-underscore variable names#57626
Merged
JeffBezanson merged 1 commit intoJuliaLang:masterfrom Mar 25, 2025
Merged
Disallow non-lhs all-underscore variable names#57626JeffBezanson merged 1 commit intoJuliaLang:masterfrom
JeffBezanson merged 1 commit intoJuliaLang:masterfrom
Conversation
KristofferC
pushed a commit
that referenced
this pull request
Mar 26, 2025
Addresses part of #57547. Currently, we only show the "all-underscore variable name not allowed" error when the offending symbol is in value position according to `compile`, but an earlier pass would keep them as raw symbols regardless. This led to raw symbols making their way out of lowering in an edge case. This change: Reject all-underscore variables unless they're being written to. Also, improve an error message slighly. (cherry picked from commit 3360a44)
mlechu
added a commit
to mlechu/JuliaLowering.jl
that referenced
this pull request
Apr 1, 2025
JuliaLang/julia#54773, JuliaLang/julia#56713, JuliaLang/julia#57626. Some changes omitted from `expand-decls` and `expand-assignment`
mlechu
added a commit
to mlechu/JuliaLowering.jl
that referenced
this pull request
Apr 2, 2025
JuliaLang/julia#54773, JuliaLang/julia#56713, JuliaLang/julia#57626. Some changes omitted from `expand-decls` and `expand-assignment`
mlechu
added a commit
to mlechu/JuliaLowering.jl
that referenced
this pull request
Apr 2, 2025
An unfortunately large commit. JuliaLang/julia#54773, JuliaLang/julia#56713, JuliaLang/julia#57626. Some changes omitted from `expand-decls` and `expand-assignment`.
mlechu
added a commit
to mlechu/JuliaLowering.jl
that referenced
this pull request
Apr 2, 2025
An unfortunately large commit. JuliaLang/julia#54773, JuliaLang/julia#56713, JuliaLang/julia#57626. Some changes omitted from `expand-decls` and `expand-assignment`.
mlechu
added a commit
to mlechu/JuliaLowering.jl
that referenced
this pull request
Apr 2, 2025
JuliaLang/julia#54773, JuliaLang/julia#56713, JuliaLang/julia#57626. Some changes omitted from `expand-decls` and `expand-assignment`.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part of #57547. Currently, we only show the "all-underscore variable name not allowed" error when the offending symbol is in value position according to
compile, but an earlier pass would keep them as raw symbols regardless. This led to raw symbols making their way out of lowering in an edge case.This change: Reject all-underscore variables unless they're being written to. Also, improve an error message slighly.
Before:
After:
Suggestions for more tests are welcome.