If the user explicitly asked for 1 thread don't add an interactive one.#57454
If the user explicitly asked for 1 thread don't add an interactive one.#57454IanButterworth merged 12 commits intoJuliaLang:masterfrom
Conversation
This basically makes the assumption that if the user asked for 1 thread they really want their program to not have threads
|
As this introduces a complexity to the setting, I think this need the docs to be updated to understand how clear this would be i.e. both |
This comment was marked as resolved.
This comment was marked as resolved.
IanButterworth
left a comment
There was a problem hiding this comment.
Makes sense to me, just needs a test alongside the ones that check threadpool sizes.
vtjnash
left a comment
There was a problem hiding this comment.
This sort of thing seems very unintuitive. Why are we getting hidden unexplained threads at all when the user didn't ask for them?
|
Because the default number of interactive threads changed. See motivation in #57087 From discussion in the multithreading call there was general agreement that while this is complication of a simple rule,
|
|
Tests should pass once #58619 lands |
|
@gbaraldi Can you assist with backporting this? |
|
Yeah, I imagined this would apply quite cleanly |
This basically makes the assumption that if the user asked for 1 thread they really want their program to not have threads