cconvert(Ref{BigFloat}, x) should return BigFloatData#57367
Merged
KristofferC merged 1 commit intomasterfrom Feb 12, 2025
Merged
cconvert(Ref{BigFloat}, x) should return BigFloatData#57367KristofferC merged 1 commit intomasterfrom
KristofferC merged 1 commit intomasterfrom
Conversation
This was referenced Feb 11, 2025
vtjnash
approved these changes
Feb 11, 2025
KristofferC
pushed a commit
that referenced
this pull request
Feb 13, 2025
#55906 changed `cconvert(Ref{BigFloat}, x::BigFloat)` to return `x.d`, but neglected to do so for other types of `x`, where it still returns a `Ref{BigFloat}` and hence is now returning the wrong type for `ccall`. Not only does this break backwards compatibility (JuliaMath/SpecialFunctions.jl#485), but it also seems simply wrong: the *whole* job of `cconvert` is to convert objects to the correct type for use with `ccall`. This PR does so (at least for `Number` and `Ref{BigFloat}`). (cherry picked from commit 6dca4f4)
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#55906 changed
cconvert(Ref{BigFloat}, x::BigFloat)to returnx.d, but neglected to do so for other types ofx, where it still returns aRef{BigFloat}and hence is now returning the wrong type forccall.Not only does this break backwards compatibility (JuliaMath/SpecialFunctions.jl#485), but it also seems simply wrong: the whole job of
cconvertis to convert objects to the correct type for use withccall. This PR does so (at least forNumberandRef{BigFloat}).