typeinfer: Enqueue CIs for ccallable entrypoints#57158
Merged
topolarity merged 2 commits intoJuliaLang:masterfrom Jan 28, 2025
Merged
typeinfer: Enqueue CIs for ccallable entrypoints#57158topolarity merged 2 commits intoJuliaLang:masterfrom
ccallable entrypoints#57158topolarity merged 2 commits intoJuliaLang:masterfrom
Conversation
This is another step in the long-term direction to have type-inference fully-explore the code graph we want to emit, largely side-stepping the vestigial `jl_type_infer` paths that we still have in type-inference for ccallable (and OpaqueClosure) This is needed for `juliac`, since the trim checks in codegen check if code was enqueued in the workqueue as expected.
vtjnash
reviewed
Jan 27, 2025
vtjnash
approved these changes
Jan 27, 2025
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
This is another step in the long-term direction to have type-inference fully-explore the code graph we want to emit, largely side-stepping the vestigial `jl_type_infer` paths that we still have in type-inference for ccallable (and OpaqueClosure) This is needed for `juliac`, since the trim checks in codegen check if code was enqueued in the workqueue as expected. --------- Co-authored-by: Jameson Nash <vtjnash@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another step in the long-term direction to have type-inference fully-explore the code graph we want to emit, largely side-stepping the vestigial
jl_type_inferpaths that we still have in type-inference for ccallable (and OpaqueClosure)This is needed for
juliac, since the trim checks in codegen check if code was enqueued in the workqueue as expected.