Skip to content

Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md, flisp parser, and REPL#57143

Merged
oscardssmith merged 4 commits intoJuliaLang:masterfrom
pthariensflame:patch-2
May 14, 2025
Merged

Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md, flisp parser, and REPL#57143
oscardssmith merged 4 commits intoJuliaLang:masterfrom
pthariensflame:patch-2

Conversation

@pthariensflame
Copy link
Copy Markdown
Contributor

@pthariensflame pthariensflame commented Jan 23, 2025 •
edited
Loading

Now that JuliaLang/JuliaSyntax.jl#525 has been merged, also add it to the flisp parser and REPL, and document it!

@Keno
Copy link
Copy Markdown
Member

Keno commented Jan 23, 2025

Also needs to be added in the flisp parser and needs to wait for the JuliaSyntax version bump.

@nsajko nsajko added the docs This change adds or pertains to documentation label Jan 23, 2025
@pthariensflame pthariensflame changed the title Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md and flisp parser Jan 24, 2025
@pthariensflame
Copy link
Copy Markdown
Contributor Author

pthariensflame commented Jan 24, 2025

@Keno @nsajko This PR now also adds support for U+1F8B2 🢲 to the flisp parser and with it the Base id char functions.

@pthariensflame pthariensflame force-pushed the patch-2 branch 2 times, most recently from 8720f42 to f4d279a Compare January 24, 2025 23:11
@nsajko nsajko added parser Language parsing and surface syntax feature Indicates new feature / enhancement requests needs tests Unit tests are required for this change and removed docs This change adds or pertains to documentation labels Jan 25, 2025
@nsajko
Copy link
Copy Markdown
Member

nsajko commented Jan 25, 2025

I'm guessing this PR will also need tests, so I added the label.

@pthariensflame
Copy link
Copy Markdown
Contributor Author

pthariensflame commented Feb 1, 2025

@nsajko I'm not sure what to test; I can't find any tests for the other arrow operators that already exist.

@pthariensflame pthariensflame changed the title Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md and flisp parser Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md, flisp parser, and REPL Feb 1, 2025
@nsajko
Copy link
Copy Markdown
Member

nsajko commented Feb 1, 2025

I'd write a simple test like this one:

@testset "RIGHTWARDS ARROW WITH LOWER HOOK" begin
    🢲(l, r) = 2l + 3r
    @test 5 === (1 🢲 1)
end

Perhaps also something to test its operator precedence?

Something like this could be fine, too:

julia/test/syntax.jl

Lines 2274 to 2280 in 9a278a2

# issue 45962
@testset "binary ⭄, ⥺, ⭃, and ⥷" begin
@test Meta.parse("a ⭄ b") == Expr(:call, :⭄, :a, :b)
@test Meta.parse("a ⥺ b") == Expr(:call, :⥺, :a, :b)
@test Meta.parse("a ⭃ b") == Expr(:call, :⭃, :a, :b)
@test Meta.parse("a ⥷ b") == Expr(:call, :⥷, :a, :b)
end

@pthariensflame
Copy link
Copy Markdown
Contributor Author

pthariensflame commented Feb 3, 2025

@nsajko Added something based on your second example and the others in that file.

@nsajko nsajko removed the needs tests Unit tests are required for this change label Feb 3, 2025
@pthariensflame
Copy link
Copy Markdown
Contributor Author

pthariensflame commented Feb 4, 2025

Is this ready to merge or are we still waiting on JuliaLang/JuliaSyntaxHighlighting.jl#9 and its followups?

@pthariensflame
Copy link
Copy Markdown
Contributor Author

pthariensflame commented Feb 6, 2025

@Keno Since the branch just happened: is this able to get in for Julia 16 after all, or do we need to undo the JuliaSyntax change that’s already included in 1.0?

@Keno Keno added the backport 1.12 Change should be backported to release-1.12 label Feb 6, 2025
@Keno
Copy link
Copy Markdown
Member

Keno commented Feb 6, 2025

It'll be added to the release branch after merge. There's a couple of other PRs in the same boat

This was referenced Feb 11, 2025
Merged
Merged
Merged
@KristofferC KristofferC mentioned this pull request Feb 26, 2025
Merged
This was referenced Mar 24, 2025
Merged
Merged
@nsajko
Copy link
Copy Markdown
Member

nsajko commented May 11, 2025

There are conflicts.

@pthariensflame
Copy link
Copy Markdown
Contributor Author

pthariensflame commented May 12, 2025

@nsajko Conflicts resolved!

@pthariensflame pthariensflame force-pushed the patch-2 branch 2 times, most recently from 9a59687 to eacd31d Compare May 13, 2025 02:51
@oscardssmith oscardssmith merged commit 229a698 into JuliaLang:master May 14, 2025
7 checks passed
@pthariensflame pthariensflame deleted the patch-2 branch May 14, 2025 22:05
@KristofferC KristofferC mentioned this pull request Jun 6, 2025
Merged
60 tasks
@pthariensflame
Copy link
Copy Markdown
Contributor Author

pthariensflame commented Jul 16, 2025

Was this ever backported to 1.12? I don’t see it in the merged 1.12 rc1 PR (#58655) but it’s been dropped from consideration for the rc2 backport PR (#59006).

@nsajko
Copy link
Copy Markdown
Member

nsajko commented Jul 17, 2025

Doesn't seem to be present in v1.12 NEWS.md:

https://docs.julialang.org/en/v1.12-dev/NEWS/

@KristofferC KristofferC mentioned this pull request Jul 22, 2025
Merged
20 tasks
@KristofferC KristofferC mentioned this pull request Aug 6, 2025
Merged
38 tasks
@KristofferC KristofferC mentioned this pull request Aug 19, 2025
Merged
27 tasks
This was referenced Sep 15, 2025
Merged
Merged
This was referenced Sep 24, 2025
Merged
Merged
@KristofferC KristofferC mentioned this pull request Oct 21, 2025
Merged
35 tasks
@KristofferC KristofferC mentioned this pull request Nov 24, 2025
Merged
22 tasks
IanButterworth pushed a commit to IanButterworth/julia that referenced this pull request Nov 30, 2025
@pthariensflame @IanButterworth
Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md, flisp parser, and REPL (J…
4c111d3 
…uliaLang#57143)

Now that JuliaLang/JuliaSyntax.jl#525 has been merged, also add it to
the flisp parser and REPL, and document it!
IanButterworth pushed a commit that referenced this pull request Nov 30, 2025
@pthariensflame @IanButterworth
Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md, flisp parser, and REPL (#…
a4d42c9 
…57143)

Now that JuliaLang/JuliaSyntax.jl#525 has been merged, also add it to
the flisp parser and REPL, and document it!
KristofferC pushed a commit that referenced this pull request Dec 16, 2025
@pthariensflame @KristofferC
Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md, flisp parser, and REPL (#…
2f7353c 
…57143)

Now that JuliaLang/JuliaSyntax.jl#525 has been merged, also add it to
the flisp parser and REPL, and document it!
@KristofferC KristofferC mentioned this pull request Dec 16, 2025
Merged
21 tasks
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Dec 17, 2025
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jan 21, 2026
@pthariensflame @kpamnany
Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md, flisp parser, and REPL (J…
14a0b93 
…uliaLang#57143)

Now that JuliaLang/JuliaSyntax.jl#525 has been merged, also add it to
the flisp parser and REPL, and document it!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature Indicates new feature / enhancement requests parser Language parsing and surface syntax

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pthariensflame @Keno @nsajko @KristofferC @oscardssmith