Move jl_task_t to julia_threads.h#57117
Merged
vtjnash merged 1 commit intoJuliaLang:masterfrom Jan 22, 2025
Merged
Conversation
c4725ae to
2734bbe
Compare
jl_task_t to julia_threads.h
d-netto
approved these changes
Jan 21, 2025
Member
d-netto
left a comment
There was a problem hiding this comment.
LGTM.
Will rebase to re-run CI -- a large number of the tests seem to have failed due to unrelated reasons.
2734bbe to
50e915b
Compare
Member
Author
|
Again CI failures, but they look unrelated? |
xal-0
pushed a commit
to xal-0/julia
that referenced
this pull request
Jan 24, 2025
This is a subset of PR JuliaLang#56477 . I hope that it will be easier to get this merged first, as it just moves things around, afterwards we can update JuliaLang#56477 and it will be considerably smaller, and will thus hopefully break less often (and in less bad ways) over time. (I can perform the required update of that PR, too). See also PR JuliaLang#57116 which contains another independent part of that PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a subset of PR #56477 by @vtjnash . I hope that it will be easier to get this merged first, as it just moves things around, afterwards we can update #56477 and it will be considerably smaller, and will thus hopefully break less often (and in less bad ways) over time. (I can perform the required update of that PR, too).
See also PR #57116 which contains another independent part of that PR.