Skip to content

Fix devcontainer definition#57006

Merged
IanButterworth merged 1 commit intoJuliaLang:masterfrom
M-PERSIC:devcontainer-fix
Jan 10, 2025
Merged

Fix devcontainer definition#57006
IanButterworth merged 1 commit intoJuliaLang:masterfrom
M-PERSIC:devcontainer-fix

Conversation

@M-PERSIC
Copy link
Copy Markdown
Contributor

@M-PERSIC M-PERSIC commented Jan 9, 2025

Starting with the Julia v1.9 container, python has no installation candidate.

At the same time, modernize devcontainer.json and remove the need for a Dockerfile.

Copy link
Copy Markdown
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm I can start a GitHub Codespace on the proposed branch and compile julia successfully in it with make -j2 (it took about 25 minutes)

@giordano giordano added the merge me PR is reviewed. Merge when all tests are passing label Jan 9, 2025
@IanButterworth IanButterworth merged commit b80dd58 into JuliaLang:master Jan 10, 2025
@oscardssmith oscardssmith removed the merge me PR is reviewed. Merge when all tests are passing label Jan 10, 2025
@M-PERSIC M-PERSIC deleted the devcontainer-fix branch January 10, 2025 09:34
@stemann
Copy link
Copy Markdown

stemann commented Nov 14, 2025

It would be nice to have this back-ported to 1.10, and 1.11 (it is in 1.12+).

@IanButterworth IanButterworth added backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 labels Nov 14, 2025
DilumAluthge pushed a commit that referenced this pull request Jan 14, 2026
@DilumAluthge DilumAluthge mentioned this pull request Jan 14, 2026
57 tasks
@fingolfin fingolfin mentioned this pull request Jan 16, 2026
DilumAluthge pushed a commit that referenced this pull request Jan 19, 2026
@DilumAluthge DilumAluthge mentioned this pull request Jan 19, 2026
71 tasks
DilumAluthge pushed a commit that referenced this pull request Jan 20, 2026
@github-actions github-actions bot removed the backport 1.11 Change should be backported to release-1.11 label Feb 7, 2026
@KristofferC KristofferC removed the backport 1.10 Change should be backported to the 1.10 release label Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants