Skip to content

subtype: fast path for Type == TypeVar#56640

Merged
N5N3 merged 1 commit intoJuliaLang:masterfrom
N5N3:fst_eq_var
Nov 26, 2024
Merged

subtype: fast path for Type == TypeVar#56640
N5N3 merged 1 commit intoJuliaLang:masterfrom
N5N3:fst_eq_var

Conversation

@N5N3
Copy link
Copy Markdown
Member

@N5N3 N5N3 commented Nov 21, 2024

close #56606

@N5N3 N5N3 added types and dispatch Types, subtyping and method dispatch needs pkgeval Tests for all registered packages should be run with this change backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 labels Nov 21, 2024
@N5N3 N5N3 requested a review from vtjnash November 21, 2024 17:27
N5N3
N5N3 commented Nov 21, 2024
View reviewed changes
vtjnash
vtjnash reviewed Nov 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@topolarity topolarity mentioned this pull request Nov 21, 2024
Closed
@oscardssmith oscardssmith added the performance Must go faster label Nov 21, 2024
This was referenced Nov 22, 2024
Merged
Merged
@N5N3 N5N3 force-pushed the fst_eq_var branch 2 times, most recently from 3922d33 to 9087b94 Compare November 22, 2024 13:17
@N5N3
Copy link
Copy Markdown
Member Author

N5N3 commented Nov 22, 2024

@nanosoldier runtests()

@nanosoldier
Copy link
Copy Markdown
Collaborator

nanosoldier commented Nov 23, 2024

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@N5N3 N5N3 marked this pull request as draft November 24, 2024 03:24
@N5N3 N5N3 marked this pull request as ready for review November 24, 2024 14:54
@N5N3
Copy link
Copy Markdown
Member Author

N5N3 commented Nov 24, 2024

@nanosoldier runtests(["MethodInspector", "Algoim", "TuePlots", "AxisKeysExtra", "GLPK", "LazySets", "Optim", "SliceSampling", "LSODA", "OrdinaryDiffEqAdamsBashforthMoulton", "OrdinaryDiffEqNordsieck", "OrdinaryDiffEqLowOrderRK", "OrdinaryDiffEqStabilizedRK", "OrdinaryDiffEqQPRK", "OrdinaryDiffEqSSPRK", "OrdinaryDiffEqFeagin", "EconomicScenarioGenerators", "ParticleInCell", "GeometryOptimization", "FinanceModels", "FSimZoo", "BoundaryValueDiffEqMIRKN", "ODEProblemLibrary", "Yunir", "SymbolicInference", "FrequencySweep", "BatchReactor", "PlugFlowReactor", "SymbolicNumericIntegration"])

@nanosoldier
Copy link
Copy Markdown
Collaborator

nanosoldier commented Nov 25, 2024

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@N5N3 N5N3 removed the needs pkgeval Tests for all registered packages should be run with this change label Nov 26, 2024
@N5N3 N5N3 merged commit 7df1dfa into JuliaLang:master Nov 26, 2024
@N5N3 N5N3 deleted the fst_eq_var branch November 26, 2024 00:16
KristofferC pushed a commit that referenced this pull request Dec 3, 2024
@N5N3
subtype: fast path for Type == TypeVar (#56640)
c3449dc 
close #56606

(cherry picked from commit 7df1dfa)
@KristofferC KristofferC mentioned this pull request Dec 3, 2024
Merged
51 tasks
KristofferC pushed a commit that referenced this pull request Dec 13, 2024
@N5N3
subtype: fast path for Type == TypeVar (#56640)
d81b037 
close #56606

(cherry picked from commit 7df1dfa)
KristofferC pushed a commit that referenced this pull request Jan 13, 2025
@N5N3
subtype: fast path for Type == TypeVar (#56640)
70b34b2 
close #56606

(cherry picked from commit 7df1dfa)
@N5N3 N5N3 mentioned this pull request Jan 13, 2025
Closed
@KristofferC KristofferC mentioned this pull request Jan 16, 2025
Open
@nsajko nsajko mentioned this pull request Jan 24, 2025
Closed
@nsajko
Copy link
Copy Markdown
Member

nsajko commented Jan 24, 2025 •
edited
Loading

Backporting this to v1.11 seems to cause precompilation to stall for a specific package on v1.11.3: #57152

@KristofferC KristofferC mentioned this pull request Jan 28, 2025
Merged
33 tasks
@KristofferC KristofferC removed backport 1.11 Change should be backported to release-1.11 backport 1.10 Change should be backported to the 1.10 release labels Jan 28, 2025
@gbaraldi gbaraldi mentioned this pull request Dec 16, 2025
Draft
@KristofferC KristofferC mentioned this pull request Mar 5, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees

No one assigned

Labels

performance Must go faster types and dispatch Types, subtyping and method dispatch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extremely slow subtype query causes unreasonable compilation times

6 participants

@N5N3 @nanosoldier @nsajko @vtjnash @KristofferC @oscardssmith