Revert "Extensions: make loading of extensions independent of what packages are in the sysimage (#52841)#56234
Conversation
c19c9fe to
ad1dc39
Compare
topolarity
left a comment
There was a problem hiding this comment.
LGTM - nice to lift this restriction (which afaiu wasn't really solving our cycle problems anyway)
I didn't look much at the code since I'm assuming this is a clean revert, but the revert seems like the right thing to do
| uuid === nothing && continue | ||
| # deps is either a list of names (deps = ["DepA", "DepB"]) or | ||
| # a table of entries (deps = {"DepA" = "6ea...", "DepB" = "55d..."} | ||
| deps = get(entry, "deps", nothing)::Union{Vector{String}, Dict{String, Any}, Nothing} |
There was a problem hiding this comment.
Is this deps lookup fix related? Does it need a test to match?
There was a problem hiding this comment.
It is partly related since this runs into #55939 due to how the manifest change with the revert. So it does in some sense already has a test.
|
edit: Ah yep, that was 385caed - I'm going to remove the backport label since I think we got everything here. |
This reverts commit 08d229f.
There are some bugs now where extensions do not load when their package has been put into the sysimage. #52841 was made because it was common to get cycles otherwise but with #55589 that should be much less of a problem.
Subsumes #54750.