Skip to content

Initial zlib support#553

Closed
choffstein wants to merge 1 commit intoJuliaLang:masterfrom
choffstein:zlib-support
Closed

Initial zlib support#553
choffstein wants to merge 1 commit intoJuliaLang:masterfrom
choffstein:zlib-support

Conversation

@choffstein
Copy link
Copy Markdown

Let's give this another go. Initial zlib support with a bit of a library redesign.

Changes:

  • zlib_wrapper.c compiler warnings
  • Error handling if zlib_wrapper ccalls fail (returning NULL on failure)
  • Deflate takes a Array{Uint8,1}, and inflate should return the same thing

@choffstein choffstein closed this Mar 9, 2012
@kmsquire
Copy link
Copy Markdown
Member

Hi Corey (@choffstein),

It looks like you deleted your julia repository. Right before that, you had a pull for zlib support. Do you mind if I fix it up and attempt to get it merged? I'm working on gzip file support, but it seems a shame to throw away your work. I should be able to arrange it so you're credited for the patch, if you care (or not, if you prefer). Let me know.

Cheers!
Kevin

@choffstein
Copy link
Copy Markdown
Author

@kmsquire Please go ahead a fix it up -- no credit necessary! I just sort of got busy and it fell off my radar...

@kmsquire
Copy link
Copy Markdown
Member

Cool, thanks!

kmsquire added a commit to kmsquire/julia that referenced this pull request Aug 28, 2012
StefanKarpinski added a commit that referenced this pull request Aug 28, 2012
Initial zlib uncompress, compress support.  Based partially on #553.
KristofferC pushed a commit that referenced this pull request Aug 4, 2018
* Fix parser

* Add test for REPL `?<command>` help syntax
KristofferC pushed a commit that referenced this pull request Aug 4, 2018
* Fix parser

* Add test for REPL `?<command>` help syntax
KristofferC pushed a commit that referenced this pull request Aug 4, 2018
* Fix parser

* Add test for REPL `?<command>` help syntax
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
* Fix parser

* Add test for REPL `?<command>` help syntax
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Oct 11, 2021
Install TagBot as a GitHub Action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants