Right arrow autocompletes at line end#54983
Merged
fingolfin merged 1 commit intoJuliaLang:masterfrom Jul 24, 2024
Merged
Conversation
fingolfin
approved these changes
Jul 24, 2024
Member
fingolfin
left a comment
There was a problem hiding this comment.
Looks good to me. I am not sure whether I'd use it in practice; or whether it even might annoy me, by triggering accidentally when I want to move to the end of the line -- though I usually use a hotkey like ctrl-e to move to the end of the line, so I am not worried. But others might find it annoying... Well, best way to find out from POV is to merge it and see what happens, and whether anyone complains. We can always revert it or put it behind a feature flag.
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Aug 17, 2024
This commit adds a REPL feature: autocompletion when the right arrow key is pressed at the end of a line (The current behavior is to do nothing). This new effect only occurs when: - the cursor is at the end of the buffer, - there is only one possible completion, and - more than 1 character is in the buffer. In this situation, the right arrow key behaves like `<Tab>`. Otherwise, the right arrow key behaves as normal. The feature was requested in JuliaLang#54539 and seems intuitive to me. One useful side effect is that, by requiring that the cursor be at the end of the line, it offers a way to avoid autcompletes within words, which I assume are almost never helpful (For example, if I type "show" in the REPL, move the cursor onto the 'o' and press `<Tab>`, I end up with "showow"). One potential drawback is that the autocomplete could occur when a user who simply wants to move the cursor to the end of the line holds down the right arrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a REPL feature: autocompletion when the right arrow key is pressed at the end of a line (The current behavior is to do nothing).
This new effect only occurs when:
In this situation, the right arrow key behaves like
<Tab>. Otherwise, the right arrow key behaves as normal.The feature was requested in #54539 and seems intuitive to me. One useful side effect is that, by requiring that the cursor be at the end of the line, it offers a way to avoid autcompletes within words, which I assume are almost never helpful (For example, if I type "show" in the REPL, move the cursor onto the 'o' and press
<Tab>, I end up with "showow"). One potential drawback is that the autocomplete could occur when a user who simply wants to move the cursor to the end of the line holds down the right arrow.Resolves #54539