Skip to content

fix var name in reseteof(s::BufferStream)#54859

Merged
vtjnash merged 2 commits intoJuliaLang:masterfrom
IanButterworth:ib/reset_eof_fix
Jun 21, 2024
Merged

fix var name in reseteof(s::BufferStream)#54859
vtjnash merged 2 commits intoJuliaLang:masterfrom
IanButterworth:ib/reset_eof_fix

Conversation

@IanButterworth
Copy link
Copy Markdown
Member

Evidently not covered by tests etc. (yet)

@IanButterworth IanButterworth added the needs tests Unit tests are required for this change label Jun 20, 2024
@IanButterworth IanButterworth removed the needs tests Unit tests are required for this change label Jun 20, 2024
@IanButterworth IanButterworth marked this pull request as ready for review June 20, 2024 15:44
@IanButterworth
Copy link
Copy Markdown
Member Author

This seems like a clear error and the test now covers the correction so I'll mark it for merge

@IanButterworth IanButterworth added the merge me PR is reviewed. Merge when all tests are passing label Jun 20, 2024
@vtjnash vtjnash merged commit 3de5e5d into JuliaLang:master Jun 21, 2024
@vtjnash vtjnash added the backport 1.11 Change should be backported to release-1.11 label Jun 21, 2024
@IanButterworth IanButterworth deleted the ib/reset_eof_fix branch June 21, 2024 17:04
KristofferC pushed a commit that referenced this pull request Jun 22, 2024
Evidently not covered by tests etc. (yet)

(cherry picked from commit 3de5e5d)
@IanButterworth IanButterworth removed the merge me PR is reviewed. Merge when all tests are passing label Jun 23, 2024
@KristofferC KristofferC removed the backport 1.11 Change should be backported to release-1.11 label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants