Skip to content

Revert "Remove jl_task_stack_buffer (#54527)"#54559

Merged
fingolfin merged 1 commit intoJuliaLang:masterfrom
fingolfin:mh/restore-jl_task_stack_buffer
May 23, 2024
Merged

Revert "Remove jl_task_stack_buffer (#54527)"#54559
fingolfin merged 1 commit intoJuliaLang:masterfrom
fingolfin:mh/restore-jl_task_stack_buffer

Conversation

@fingolfin
Copy link
Copy Markdown
Member

This reverts commit 516ab55.

Unfortunately my PR was premature and broke our CI tests. I'll
get rid of the last remaining jl_task_stack_buffer and once
that is done, will re-submit the removal PR.

This reverts commit 516ab55.

Unfortunately my PR was premature and broke our CI tests. I'll
get rid of the last remaining `jl_task_stack_buffer` and once
that is done, will re-submit the removal PR.
@fingolfin fingolfin merged commit 9e6a29c into JuliaLang:master May 23, 2024
@fingolfin fingolfin deleted the mh/restore-jl_task_stack_buffer branch May 23, 2024 10:22
lazarusA pushed a commit to lazarusA/julia that referenced this pull request Jul 12, 2024
This reverts commit 516ab55.

Unfortunately my PR was premature and broke our CI tests. I'll
get rid of the last remaining `jl_task_stack_buffer` and once
that is done, will re-submit the removal PR.
fingolfin added a commit to fingolfin/julia that referenced this pull request Jan 21, 2025
This was removed previously in PR JuliaLang#54527 but had to be reverted in
PR JuliaLang#54559 as one usage remained (more by accident then by design).
This has since then been resolved.
fingolfin added a commit to fingolfin/julia that referenced this pull request Jan 21, 2025
This was removed previously in PR JuliaLang#54527 but had to be reverted in
PR JuliaLang#54559 as one usage remained (more by accident then by design).
This has since then been resolved.
d-netto pushed a commit that referenced this pull request Jan 21, 2025
This was removed previously in PR #54527 but had to be reverted in PR
#54559 as one usage remained (more by accident then by design). This has
since then been resolved.

This is also part of PR #56477 but that seems stalled right now, and in
fact merging parts of it now may make the review of it easier later
on...
@nsajko nsajko added the revert This reverts a previously merged PR. label Jan 21, 2025
xal-0 pushed a commit to xal-0/julia that referenced this pull request Jan 24, 2025
This was removed previously in PR JuliaLang#54527 but had to be reverted in PR
JuliaLang#54559 as one usage remained (more by accident then by design). This has
since then been resolved.

This is also part of PR JuliaLang#56477 but that seems stalled right now, and in
fact merging parts of it now may make the review of it easier later
on...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

revert This reverts a previously merged PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants