typeintersect: fix potential free TypeVar caused by chained inner var.#53675
typeintersect: fix potential free TypeVar caused by chained inner var.#53675N5N3 merged 1 commit intoJuliaLang:masterfrom
TypeVar caused by chained inner var.#53675Conversation
7a793bc to
a3c09f4
Compare
Noticed when working on 02f27c2. The substitution and re-sorting of inner vars are incomplete on master. This commit re-organized the code by: 1. Flatten the inner vars into a reversed list and handling them just like vars in norm bindings. 2. Then perform a global re-sorting on all vars. 3. After that, the inner vars get frozen and dependent bounds are refreshed.
ffdbce2 to
d47c237
Compare
|
@nanosoldier |
|
The package evaluation job you requested has completed - possible new issues were detected. |
|
@nanosoldier |
|
The package evaluation job you requested has completed - possible new issues were detected. |
vtjnash
left a comment
There was a problem hiding this comment.
SGTM. I didn't follow all of the code rearrangements, but the concept sounds good and it passes tests
…ar. (#53675) Noticed when working on 02f27c2. The substitution and re-sorting of inner vars are incomplete on master. This commit re-organized the code by: 1. Flatten the inner vars into a reversed list and handling them just like vars in norm bindings. 2. Then perform a global re-sorting on all vars. 3. After that, the inner vars get frozen and dependent bounds are refreshed. (cherry picked from commit 3d34f11)
|
Note, I backported this to 1.11 as well since without it there were some merge conflicts. |
…ar. (#53675) Noticed when working on 02f27c2. The substitution and re-sorting of inner vars are incomplete on master. This commit re-organized the code by: 1. Flatten the inner vars into a reversed list and handling them just like vars in norm bindings. 2. Then perform a global re-sorting on all vars. 3. After that, the inner vars get frozen and dependent bounds are refreshed. (cherry picked from commit 3d34f11)
Noticed when working on 02f27c2. The substitution and re-sorting of inner vars are incomplete on master. This commit re-organized the code by: