Skip to content

add initial support for OpenBSD#53633

Merged
IanButterworth merged 9 commits intoJuliaLang:masterfrom
semarie:openbsd-initial
Mar 29, 2024
Merged

add initial support for OpenBSD#53633
IanButterworth merged 9 commits intoJuliaLang:masterfrom
semarie:openbsd-initial

Conversation

@semarie
Copy link
Copy Markdown
Contributor

@semarie semarie commented Mar 7, 2024

These commits add initial support of OpenBSD in julia.

It isn't strictly enough to make julia runable on OpenBSD (see #53632), but it covers the larger part.

semarie added 6 commits March 7, 2024 07:55
@semarie
missing \n in error message
ef02318
@semarie
deps: adjustments in common
bb42795 
- libsuitesparse: use $(MAKE) instead of hardcoding "make" (it is "gmake" on BSD)
- patchelf: pass MAKE variable
- libssh2: pass -fPIC if need (permit libgit2 to link on OpenBSD)
@semarie
deps: openbsd specifics bits
690971d 
- libgit2: search iconv.h in right directory
- pcre2: avoid RWX memory by disabling jit on OpenBSD
- libssh2
- libsuitesparse
- mbedtls
@semarie
openbsd: normalize_triplet
ba7c3f0
@semarie
add OpenBSD support
2887964
@semarie
openbsd: no profiling for now, but be kind and not error out
0d32545
@semarie semarie mentioned this pull request Mar 7, 2024
Open
10 tasks
Keno
Keno reviewed Mar 8, 2024
View reviewed changes
Keno
Keno reviewed Mar 8, 2024
View reviewed changes
Keno
Keno reviewed Mar 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable start overall

fingolfin
fingolfin reviewed Mar 8, 2024
View reviewed changes
@semarie @fingolfin
base/binaryplatforms.jl: "freebsd" is isfreebsd()
bd33908 
Co-authored-by: Max Horn <max@quendi.de>
@semarie
Copy link
Copy Markdown
Contributor Author

semarie commented Mar 25, 2024

there is something I should do to make progress here ?

@oscardssmith oscardssmith added the building Build system, or building Julia or its dependencies label Mar 25, 2024
@oscardssmith
Copy link
Copy Markdown
Member

oscardssmith commented Mar 25, 2024

No. I think this looks ready to merge.

@oscardssmith oscardssmith added the merge me PR is reviewed. Merge when all tests are passing label Mar 25, 2024
fingolfin
fingolfin approved these changes Mar 25, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@StefanKarpinski
Copy link
Copy Markdown
Member

StefanKarpinski commented Mar 25, 2024

Do we have any prospect for CI for OpenBSD?

@semarie
Copy link
Copy Markdown
Contributor Author

semarie commented Mar 25, 2024

@IanButterworth
Copy link
Copy Markdown
Member

IanButterworth commented Mar 29, 2024

Do you want any of the commit messages to be retained in the squash merge description here? Github's default squash merge message is just the original PR post, so if you do perhaps elaborate there?

@ararslan
Copy link
Copy Markdown
Member

ararslan commented Mar 29, 2024 •
edited
Loading

Do we have any prospect for CI for OpenBSD?

Buildkite provides official OpenBSD binaries for the agent with every release. Like Windows, our FreeBSD CI is set up to run under KVM on Linux, so we could theoretically make an analogous setup for OpenBSD.

@semarie
Copy link
Copy Markdown
Contributor Author

semarie commented Mar 29, 2024

@IanButterworth I am fine with default squash merge. I did several differents commits to help reviewing (and not mix too many things)

@IanButterworth IanButterworth merged commit e26d140 into JuliaLang:master Mar 29, 2024
@semarie semarie deleted the openbsd-initial branch March 29, 2024 16:52
@IanButterworth IanButterworth removed the merge me PR is reviewed. Merge when all tests are passing label Apr 5, 2024
ararslan pushed a commit that referenced this pull request Apr 15, 2025
@semarie @ararslan
Fix __stack_chk_guard entry in version script
678c448 
(Cherry-picked from PR #53633)
@ararslan ararslan mentioned this pull request Apr 15, 2025
Merged
ararslan added a commit that referenced this pull request Apr 16, 2025
@ararslan
[release-1.10] Backport version script fixes (#58130)
afc9bff 
This includes three commits that fix the version script for use with
newer LLD. This has already been fixed on 1.11, 1.12, and master.

Commits were cherry-picked from #55363, #57874, and #53633.
KristofferC pushed a commit that referenced this pull request Jul 3, 2025
@semarie
Fix __stack_chk_guard entry in version script
3869a07 
(Cherry-picked from PR #53633)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keno Keno Keno left review comments

@fingolfin fingolfin fingolfin approved these changes

@oscardssmith oscardssmith oscardssmith approved these changes

Assignees

No one assigned

Labels

building Build system, or building Julia or its dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@semarie @oscardssmith @StefanKarpinski @IanButterworth @ararslan @fingolfin @Keno