Skip to content

Add nested precomp highlight debug#53111

Merged
IanButterworth merged 1 commit intoJuliaLang:masterfrom
IanButterworth:ib/loading_fixes
Feb 9, 2024
Merged

Add nested precomp highlight debug#53111
IanButterworth merged 1 commit intoJuliaLang:masterfrom
IanButterworth:ib/loading_fixes

Conversation

@IanButterworth
Copy link
Copy Markdown
Member

@IanButterworth IanButterworth commented Jan 30, 2024 •
edited
Loading

Fixes the pkgimage.mk stdlib dep tree which was slightly wrong and causing some nested precompilation

And adds debugs that identified the above issue, and have been useful for debugging #53081

i.e.

% JULIA_DEBUG=nested_precomp ./julia -q

(@v1.11) pkg> precompile
Precompiling project...
  103 dependencies successfully precompiled in 34 seconds. 40 already precompiled.
  2 dependencies had output during precompilation:
┌ FillArrays → FillArraysPDMatsExt
│  ┌ Debug: Nested precompilation: FillArraysPDMatsExt > FillArraysSparseArraysExt
│  └ @ Base loading.jl:2520
└  
┌ Symbolics → SymbolicsPreallocationToolsExt
│  ┌ Debug: Nested precompilation: SymbolicsPreallocationToolsExt > SymbolicsForwardDiffExt
│  └ @ Base loading.jl:2520
│  ┌ Warning: Module SymbolicsPreallocationToolsExt with build ID ffffffff-ffff-ffff-0008-f643010bcdb7 is missing from the cache.
│  │ This may mean SymbolicsPreallocationToolsExt [d479e226-fb54-5ebe-a75e-a7af7f39127f] does not support precompilation but is imported by a module that does.
│  └ @ Base loading.jl:2121
│  ┌ Error: Error during loading of extension SymbolicsPreallocationToolsExt of Symbolics, use `Base.retry_load_extensions()` to retry.

@IanButterworth IanButterworth added the packages Package management and loading label Jan 30, 2024
@IanButterworth IanButterworth mentioned this pull request Jan 30, 2024
Closed
2 tasks
IanButterworth
IanButterworth commented Jan 30, 2024
View reviewed changes
@vchuravy
Copy link
Copy Markdown
Member

vchuravy commented Jan 30, 2024

Should we fast-track f05f93d first?

@IanButterworth IanButterworth mentioned this pull request Jan 31, 2024
Merged
KristofferC pushed a commit that referenced this pull request Jan 31, 2024
@IanButterworth
fix pkgimage.mk tree (#53133)
81deb5e 
Taken from #53111
@IanButterworth IanButterworth changed the title Fix pkgimage.mk stdlib dep tree. Add nested precomp highlight debug Add nested precomp highlight debug Feb 8, 2024
@IanButterworth
Copy link
Copy Markdown
Member Author

IanButterworth commented Feb 8, 2024

#53112 is the follow-on for this

@IanButterworth IanButterworth added the merge me PR is reviewed. Merge when all tests are passing label Feb 8, 2024
@IanButterworth IanButterworth merged commit 63e95d4 into JuliaLang:master Feb 9, 2024
@IanButterworth IanButterworth removed the merge me PR is reviewed. Merge when all tests are passing label Feb 9, 2024
@mortenpi mortenpi mentioned this pull request Feb 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KristofferC KristofferC KristofferC left review comments

Assignees

No one assigned

Labels

packages Package management and loading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IanButterworth @vchuravy @KristofferC