fix isequal_normalized for combining-char reordering#52447
Merged
StefanKarpinski merged 9 commits intomasterfrom Dec 19, 2023
Merged
fix isequal_normalized for combining-char reordering#52447StefanKarpinski merged 9 commits intomasterfrom
StefanKarpinski merged 9 commits intomasterfrom
Conversation
stevengj
commented
Dec 8, 2023
Member
Author
|
CI failures seem unrelated. |
Member
Author
|
Should be good to merge? |
Member
StefanKarpinski
left a comment
There was a problem hiding this comment.
LGTM (already merged)
KristofferC
pushed a commit
that referenced
this pull request
Dec 23, 2023
Fixes #52408. (Note that this function was added in Julia 1.8, in #42493.) In the future it would be good to further optimize this function by adding a fast path for the common case of strings that are mostly ASCII characters. Perhaps simply skip ahead to the first byte that doesn't match before we begin doing decomposition etcetera. (cherry picked from commit 3b250c7)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52408.
(Note that this function was added in Julia 1.8, in #42493.)
In the future it would be good to further optimize this function by adding a fast path for the common case of strings that are mostly ASCII characters. Perhaps simply skip ahead to the first byte that doesn't match before we begin doing decomposition etcetera.