bugfix for dot of Hermitian{noncommutative}#52333
Merged
Conversation
andreasnoack
approved these changes
Nov 28, 2023
stevengj
commented
Nov 28, 2023
dkarrasch
reviewed
Nov 29, 2023
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
defa180 to
2dc0c53
Compare
Member
Author
|
|
KristofferC
pushed a commit
that referenced
this pull request
Dec 12, 2023
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de> (cherry picked from commit 53f1eb8)
KristofferC
added a commit
that referenced
this pull request
Dec 17, 2023
Backported PRs: - [x] #51234 <!-- Fix getfield codegen for tuple inputs and unknown symbol fields. --> - [x] #52170 <!-- fix invalidations related to `ismutable` --> - [x] #52342 <!-- Add single-term multiplication for `AbstractQ` on v1.10 and above --> - [x] #52333 <!-- bugfix for dot of Hermitian{noncommutative} --> - [x] #52407 <!-- channels: fix memory ordering violation in iterate --> - [x] #52405 <!-- Bump LLVM to 15.0.7+10 to fix GC issue --> - [x] #52441 <!-- Remove `Pkg` dependency from `SuiteSparse_jll` --> - [x] #52367 <!-- docs: add notes about scratchspaces in depot --> - [x] #52456 <!-- Make `jl_write_coverage_data` dllexported again --> - [x] #52294 <!-- GC scheduler refinements --> - [x] #52359 <!-- make custom log macros work --> - [x] #52548
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug identified by @andreasnoack in #52318, where
dot(A,B)was giving incorrect result forHermitianmatrices over fields like quaternions whereconj(a)*conj(b) ≠ conj(a*b)(The bug was introduced in #32827, which was part of Julia 1.4.)