Revert "replace unsafe_convert methods with safe cconvert ones"#51860
Closed
Revert "replace unsafe_convert methods with safe cconvert ones"#51860
Conversation
Member
|
It looks like this is an effect_system / caching issue. Somewhere along the way we compile or run a copy of |
Member
|
Looks like there are two interconnected issues with how effects are hooked up that lead to this fatal result:
|
vtjnash
added a commit
that referenced
this pull request
Oct 25, 2023
When inference decided it was not necessary to cache the object, it also skipped all of the work required to make the code valid, which typeinf_ext depends upon. This resulted in caching invalid data, causing effects tests to break unpredictably. This change ensures that we always update the InferenceState with the final result, so that typeinf_ext can get the correct results out of it for internal codegen use. Fixes one of the issues uncovered in #51860
vtjnash
added a commit
that referenced
this pull request
Oct 25, 2023
When inference decided it was not necessary to cache the object, it also skipped all of the work required to make the code valid, which typeinf_ext depends upon. This resulted in caching invalid data, causing effects tests to break unpredictably. This change ensures that we always update the InferenceState with the final result, so that typeinf_ext can get the correct results out of it for internal codegen use. Fixes one of the issues uncovered in #51860
vtjnash
added a commit
that referenced
this pull request
Oct 25, 2023
When inference decided it was not necessary to cache the object, it also skipped all of the work required to make the code valid, which typeinf_ext depends upon. This resulted in caching invalid data, causing effects tests to break unpredictably. This change ensures that we always update the InferenceState with the final result, so that typeinf_ext can get the correct results out of it for internal codegen use. Fixes one of the issues uncovered in #51860
vtjnash
added a commit
that referenced
this pull request
Oct 25, 2023
When inference decided it was not necessary to cache the object, it also skipped all of the work required to make the code valid, which typeinf_ext depends upon. This resulted in caching invalid data, causing effects tests to break unpredictably. This change ensures that we always update the InferenceState with the final result (when `must_be_codeinf` is true), so that typeinf_ext can get the correct results out of it for internal codegen use. Previously we were disregarding that flag in some cases. Fixes one of the issues uncovered in #51860
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #51764. CI is failing on master after that PR.