Skip to content

fix missing methods in ml_matches results#50962

Merged
vtjnash merged 1 commit intomasterfrom
jn/mlmissingmatches
Aug 18, 2023
Merged

fix missing methods in ml_matches results#50962
vtjnash merged 1 commit intomasterfrom
jn/mlmissingmatches

Conversation

@vtjnash
Copy link
Copy Markdown
Member

@vtjnash vtjnash commented Aug 17, 2023

This was resulting in it being too aggressive at filtering out "duplicate" results, resulting in possible inference mistakes or missing guardsig entries.

Fixes: #50722 (comment)

This was resulting in it being too aggressive at filtering out
"duplicate" results, resulting in possible inference mistakes or missing
guardsig entries.
@JeffBezanson JeffBezanson added types and dispatch Types, subtyping and method dispatch bugfix This change fixes an existing bug labels Aug 17, 2023
@vtjnash
Copy link
Copy Markdown
Member Author

vtjnash commented Aug 18, 2023

Error in testset SparseArrays/higherorderfns:
Test Failed at C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-6360aac254\share\julia\stdlib\v1.11\SparseArrays\test\higherorderfns.jl:99
  Expression: #= C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-6360aac254\share\julia\stdlib\v1.11\SparseArrays\test\higherorderfns.jl:99 =# @allocated(map!(*, X, A, B, C)) < 300
   Evaluated: 552 < 300

:/

@vtjnash vtjnash merged commit 762801c into master Aug 18, 2023
@vtjnash vtjnash deleted the jn/mlmissingmatches branch August 18, 2023 16:09
KristofferC pushed a commit that referenced this pull request Mar 26, 2025
This was resulting in it being too aggressive at filtering out
"duplicate" results, resulting in possible inference mistakes or missing
guardsig entries.

Fixes:
#50722 (comment)
(cherry picked from commit 762801c)
nickrobinson251 pushed a commit to RelationalAI/julia that referenced this pull request Mar 27, 2025
This was resulting in it being too aggressive at filtering out
"duplicate" results, resulting in possible inference mistakes or missing
guardsig entries.

Fixes:
JuliaLang#50722 (comment)
(cherry picked from commit 762801c)
nickrobinson251 added a commit to RelationalAI/julia that referenced this pull request Mar 27, 2025
This was resulting in it being too aggressive at filtering out
"duplicate" results, resulting in possible inference mistakes or missing
guardsig entries.

Fixes:
JuliaLang#50722 (comment)
(cherry picked from commit 762801c)

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
KristofferC pushed a commit that referenced this pull request Mar 31, 2025
This was resulting in it being too aggressive at filtering out
"duplicate" results, resulting in possible inference mistakes or missing
guardsig entries.

Fixes:
#50722 (comment)
(cherry picked from commit 762801c)
KristofferC pushed a commit that referenced this pull request Mar 31, 2025
This was resulting in it being too aggressive at filtering out
"duplicate" results, resulting in possible inference mistakes or missing
guardsig entries.

Fixes:
#50722 (comment)
(cherry picked from commit 762801c)
KristofferC pushed a commit that referenced this pull request Jun 5, 2025
This was resulting in it being too aggressive at filtering out
"duplicate" results, resulting in possible inference mistakes or missing
guardsig entries.

Fixes:
#50722 (comment)
(cherry picked from commit 762801c)
KristofferC pushed a commit that referenced this pull request Jul 3, 2025
This was resulting in it being too aggressive at filtering out
"duplicate" results, resulting in possible inference mistakes or missing
guardsig entries.

Fixes:
#50722 (comment)
(cherry picked from commit 762801c)
@KristofferC KristofferC mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This change fixes an existing bug types and dispatch Types, subtyping and method dispatch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants